-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Registry Standard from DR SCS-0212 #458
Conversation
174e07c
to
357b925
Compare
Just a suggestion, but maybe a section on "compliance and security" in the "Requirements for container registries" document would be beneficial. The following aspects could be considered for that section:
|
I am not quite sure if that was done in any other standards so far, but maybe something should be mentioned like the following in the "Container registry standard document" : |
Suggestion: add a closing/conclusion section to the "Container registry standard document" describing the importance of adhering to these standards and the expected impact on the SCS project and its users. |
Although this is mentioned: "This document should finally lead to a decision about the container registry used in the implementation." |
Standards/scs-0218-v1-container-registry-for-scs-standard-implementation.md
Outdated
Show resolved
Hide resolved
Standards/scs-0218-v1-container-registry-for-scs-standard-implementation.md
Outdated
Show resolved
Hide resolved
Standards/scs-0218-v1-container-registry-for-scs-standard-implementation.md
Outdated
Show resolved
Hide resolved
Interesting idea, although I'm not sure if the projects themself even do stuff like compliance. In the end, it's probably more the responsibility of the providers (using these projects) and their way of setting them up thats matters for compliance and security as well as data protection. Its probably possible for most of these projects to be compliant to standard X, but the project owners most of the time won't have time (or even money) to do that. And even if that would be the case, on what basis would you do a compliance test? The "best, most secure" setup? This wouldn't automatically translate to compliant setups for users of their software.
I think we shouldn't do that either. Normally (at least IMO) a revision process should be started after some time in order to check if the standard is up-to-date. If changes are done, a new version is created, so SCS won't change the old standard.
If someone is committed to SCS and the provided standards, I don't think they would need a conclusion. The introduction/motivation section for the standards should be reasoning enough and an additional section only creates extra "overhead".
Hmmm, interoperability could be interesting, though I'm not quite sure for whom. Providers don't really need it, except if they would change the deployed registry, which probably won't really happen that much. API interoperability is probably on the same level, since customers only see a very small endpoint (to download their images) and since most registries work with the normal types of container solutions, I would assume that they're at least interoperable in this regard. Possible auth mechanisms in the registries are indeed interesting and should be checked and mentioned. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My comments were resolved, therefore I approve this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This commit adds the standard for K8s container registries. It also fixes some minor typos. Signed-off-by: Hannes Baum <[email protected]>
This MR splits the for now Decision Record for K8s registries into a Standard and a Decision Record.
A standard for this topic was long due and the Decision Record already contained much of the work.
The DR itself will now showcase the internal decision of SCS to use Harbor, but doesn't influence external decisions.
Closes SovereignCloudStack/issues#470