-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: make rookify execute on run only #88
Conversation
Signed-off-by: Boekhorst <[email protected]>
eee5cb6
to
96f1ebd
Compare
Dear @boekhorstb1, I like the intention of not execute Rookify by mistake. Therefore I would love to see How about the following changes:
|
Hi @NotTheEvilOne ! I think it would look rather like this, if it preflight mode should be used only:
We could add the migrate parameter. But Im not sure how.
that way you can run
|
Alright, we came to the following decision: Going to use --dry-run as default, when no args given reason: less is more |
Signed-off-by: Boekhorst <[email protected]>
Looks now like this: .venv/bin/rookify --help
usage: Rookify [-h] [-d] [-s] [-m]
options:
-h, --help show this help message and exit
-d, --dry-run
-s, --show-states Show states of the modules.
-m, --migrate Run the migration. |
Signed-off-by: Tobias Wolf <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
run
to execute and run--help
per defaultcloses #87