Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle access to undefined states gracefully #85

Merged
merged 4 commits into from
Oct 21, 2024

Conversation

NotTheEvilOne
Copy link
Contributor

This PR fixes issues if states are accessed in e.g. preflight methods but are not registered. This may happen if executed in "dry-run mode".

An example use case for this kind of access is to skip checks if migration has been started or already completed for the module in question.

Fixes: #76

@NotTheEvilOne NotTheEvilOne self-assigned this Sep 10, 2024
@NotTheEvilOne NotTheEvilOne added bug Something isn't working framework Core components of rookify labels Sep 10, 2024
@NotTheEvilOne NotTheEvilOne force-pushed the fix/76-dry-run-error branch 2 times, most recently from 7e47563 to d5856d4 Compare September 24, 2024 07:39
@NotTheEvilOne NotTheEvilOne merged commit b745bcd into main Oct 21, 2024
3 checks passed
@NotTheEvilOne NotTheEvilOne deleted the fix/76-dry-run-error branch October 21, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working framework Core components of rookify
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rookify dry run error
2 participants