Merged
Conversation
Member
matteospanio
commented
Jan 5, 2026
matteospanio
commented
- closes 🐛 Bug: Manager users cannot open table views in admin dashboard #7
- closes 🐛 Bug: Admin flashes are not displayed correctly #5
- Add password editing when admin creates a new user
Co-authored-by: matteospanio <50635581+matteospanio@users.noreply.github.com>
…e-display Fix: Render flash messages on all admin pages
Previously, manager users could log in to the admin dashboard but could not access any table views (Users, Dishes, Menus, Attributes, Logs). This was because most views used SecureModelView which only allowed admin users. Changes: - Added ManagerEditableView class for full CRUD access (managers + admins) - Added ManagerReadOnlyView class for read-only access with dynamic permissions based on role (admins get full access, managers read-only) - Updated UserAdminView to inherit from ManagerReadOnlyView so managers can view users but not edit them - Updated MenuAdminView to inherit from ManagerEditableView for full access - Updated Dishes and Attributes views to use ManagerEditableView - Updated tests to reflect new expected behavior Manager permissions now: - Users: Read-only (view list/details, no edit) - Menus, Dishes, Attributes: Full CRUD access - Request Logs: Read-only (already working, kept as-is) All tests pass: admin users retain full access, manager users can now access all views with appropriate permissions. Fixes #[issue-number]
…-access-1X3Br Claude/fix manager table access 1 x3 br
Update to v0.2.1
Admin can set user password when creating a new user and managers can view record details
Fix whitespaces in all files
Remove an old test line that after merge conflict was in the wrong place
matteospanio
added
bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.