fix(Input): number spin buttons, ID generation, layout shift & a11y - #146
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR resolves the requested issues regarding the Input component's behavior and layout stability, while also layering in missing accessibility properties for the error/hint layout.
Changes Made:
index.csssuccessfully overrides browser-webkit-appearanceand-moz-appearancestyles.useId()correctly supplies a stable ID to the input element whenidandlabelare absent.min-h-[18px]to ensure no CLS penalties or layout shifts occur when theerrorstate toggles the hint visibility.aria-describedbyandaria-invalidto explicitly link the input to its respective error and hint<p>tags for screen readers.(Note: The primary CSS and layout shift changes were already present in
main, so this PR specifically supplements the existing fixes with standard ARIA mappings to ensure robust a11y).Closes #123