test(SorobanPanel): cover non-array JSON args validation (#118 upgrade) - #141
Merged
k-deejah merged 2 commits intoJun 28, 2026
Merged
Conversation
Issue Sorokit#118's SorobanPanel guard rejects valid JSON that is not an array (e.g. {} or 42) so a non-array is never forwarded to invokeContract. The existing test only covered malformed JSON syntax, leaving the non-array case — the actual security fix — untested. Add tests asserting: - a JSON object {} is rejected with 'Arguments must be a JSON array' - a JSON number 42 is rejected with the same error - a valid JSON array passes validation and reaches the success state SorobanPanel: 5 tests passing. Lint clean. Closes Sorokit#118
…rray-validation # Conflicts: # src/components/SorobanPanel.test.tsx
|
@KayProject Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
All three validation fixes from issue #118 are already implemented on
main:amount >= 0.0000001(Send disabled + error below threshold) — tested!Array.isArray(parsed)→Arguments must be a JSON array)The SorobanPanel non-array guard — the actual security fix preventing a non-array reaching
invokeContract— had no test. The existing SorobanPanel test only covered malformed JSON syntax (invalid json {), not valid-but-non-array JSON. This PR closes that gap.Tests added
{}is rejected withArguments must be a JSON array42is rejected with the same error["arg1", 42]passes validation and reaches the success state (no validation error)Verification
npm test(SorobanPanel): 5 passed.npm run lint: clean.npm run build: unaffected by this test-only change; notetsc -bhas a pre-existing, unrelatedTS1484error insrc/verify-exports.tsonmain.Closes #118