#24 fix(a11y,Sidebar): focus not trapped on mobile open, Escape key does not close drawer, nav missing aria-label - #137
Merged
Conversation
…pagination touch targets
…batimModuleSyntax error
…add nav aria-label
|
@Olamidepy Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
… mock configuration, and Radix Slot children requirements
…types/qrcode, and annotate error parameter in QRCode.tsx
Contributor
Author
|
@k-deejah Kindly merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #24
Focus Trapping on Mobile: When the sidebar transitions to open on mobile screens (< 1024px), keyboard focus is automatically shifted to the first navigation item (Wallet). Tab navigation is now locked inside the sidebar, wrapping correctly between the first and last elements.
element insideEscape Key Support & Focus Restoration: Pressing the Escape key now closes the sidebar drawer. Focus is automatically restored to the element that triggered the menu (the toggle button), preventing keyboard navigation from being lost.
Landmark Context: Added aria-label="Main navigation" to the
Sidebar.tsx
so screen readers can uniquely identify the sidebar navigation area.