feat(WalletScreen,QRCode): accessible receive QR code (#121 upgrade) - #132
Merged
Conversation
…readers (Sorokit#121) The WalletScreen receive surface (issue Sorokit#121) renders the address as a <canvas> QR code, which is opaque to assistive tech — screen reader users got no indication a QR code was present. Upgrade the existing receive-funds implementation with accessibility: - QRCode: add an `ariaLabel` prop and expose the canvas as `role="img"` with an accessible name (falls back to `label`, then a generic description). - WalletScreen: pass a descriptive label naming the receiving address. Adds QRCode tests for the role/name behaviour. Closes Sorokit#121
|
@jadonamite Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
…r-a11y # Conflicts: # src/components/QRCode.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
The core of issue #121 — removing the duplicate
AccountCard, adding a QR receive section, and a copyableInfoCell— already landed onmain(commit66b8cc6). This PR upgrades that receive-funds surface with the accessibility piece it was missing.Problem
The receive QR is rendered as a
<canvas>, which is completely opaque to assistive technology. A screen-reader user onWalletScreengets no indication that a QR code for receiving funds is present.Change
QRCode: add an optionalariaLabelprop and expose the canvas asrole="img"with an accessible name. The name resolves toariaLabel→label→ a generic"QR code"fallback, so existing call sites gain a sensible default with no change required.WalletScreen: pass a descriptive label naming the receiving address (QR code to receive funds at address G…).role="img"exposure and accessible-name resolution.Verification
npm test(QRCode suite): 10 passed.npm run lint: clean.npm run build: my files type-check cleanly. Note:tsc -bcurrently fails on a pre-existing, unrelated error insrc/verify-exports.ts(TS1484type-only import) that is present onmainbefore this change — out of scope for this PR.Closes #121