feat: transaction validation, integration tests, and performance benchmarks#79
Merged
Merged
Conversation
…ce benchmarks Implements three improvements to strengthen correctness and observability: - **Sorokit#48 validateTransaction()**: Adds `validateTransaction(xdr, rules?)` to `src/transaction/validateTransaction.ts`. Runs pre-submission checks against an XDR string — receiver public key validity, positive amounts, fee sanity (100–100,000 stroops default), and optional network passphrase match. Accepts custom validation rules via `rules.custom[]`. Returns a typed `TransactionValidationReport` with `valid`, per-field `issues`, and summary metadata. Exported from `src/transaction/index.ts` and `src/index.ts`. 25 tests added in `src/tests/validateTransaction.test.ts`. - **Sorokit#49 Integration tests**: Creates `src/tests/integration/` with four test suites covering real interaction patterns with mocked Horizon/RPC boundaries: wallet-account workflow, buildPayment→sign→submit flow, Soroban contract simulate→execute chain, and account/transaction streaming and monitoring. - **Sorokit#50 Performance benchmarks**: Creates `src/tests/benchmarks/index.bench.ts` using vitest bench API. Covers result construction, XDR validation, utility functions, client construction, and fee arithmetic. Adds `npm run bench` script. Adds `.github/workflows/benchmark.yml` CI workflow that runs benchmarks on Node 18 and 20 and posts results as PR comments. Closes Sorokit#48 Closes Sorokit#49 Closes Sorokit#50
|
@amandasmyths Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Collaborator
|
@amandasmyths kindly resolve the conflict. nice work. |
Collaborator
|
@amandasmyths kindly resolve the conflict. Nice work. |
…c/transaction/index.ts Kept both validateTransaction (PR Sorokit#79) and validateTransactionXdr (upstream). Removed duplicate export blocks; types from validateTransaction.ts with name collisions (ValidationRules, TransactionValidationReport) are intentionally scoped to ./transaction/validateTransaction to avoid re-export ambiguity.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
validateTransaction(xdr, rules?)utility for pre-submission checks: receiver validity, positive amounts, fee sanity, network passphrase match, and optional custom rules. Exported fromsrc/transaction/index.tsandsrc/index.ts.src/tests/integration/with four suites covering end-to-end workflows: wallet→account, build→sign→submit, Soroban contract simulation/execution, and account/transaction streaming.src/tests/benchmarks/index.bench.tsusing vitest bench API, anpm run benchscript, and.github/workflows/benchmark.ymlCI workflow that runs benchmarks on Node 18/20 and posts results as PR comments.Test plan
npm run test— all new tests pass (pre-existing failures intransaction.test.tsandsoroban.test.tsare unchanged frommain)npm run typecheck— only the pre-existingdeployContract.tserror remainsnpm run bench— benchmark suite runs without errortest.ymlandbuild.ymlworkflows pass (pre-existing DTS failure inbuild.ymlis onmaintoo)benchmark.ymlworkflow runs benchmarks on Node 18 and 20Closes #48
Closes #49
Closes #50