feat: implement fee estimation caching to reduce RPC calls#53
Merged
Just-Bamford merged 2 commits intoJun 24, 2026
Conversation
|
@samjay8 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
- Add SHA256-keyed cache lookup in estimateFee() before calling simulateTransaction() - Cache hits short-circuit the RPC call entirely; misses simulate then populate the cache - Default TTL is 5 minutes (DEFAULT_FEE_CACHE_TTL_MS); callers can override per-call - Wire client's SorokitCache into transaction.estimateFee via createSorokitClient - Add transaction.test.ts covering cache hit, miss, expiry, default/custom TTL, and backward compatibility when no cache is provided Closes Sorokit#8
samjay8
force-pushed
the
feat/implement-fee-estimation
branch
from
66585bf to
4c7af32
Compare
Collaborator
|
@samjay8 the code looks good to me. resolve the conflict so i can merge |
Contributor
Author
|
@Just-Bamford , it has been resolved, thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #8
Summary
estimateFee()now checks the pluggableSorokitCache(if provided) using a SHA256 hash of the transaction XDR as the cache key, before ever callingsimulateTransaction().FeeEstimateresult in the cache for future calls.DEFAULT_FEE_CACHE_TTL_MS = 300_000tosrc/shared/constants.ts. The TTL is configurable per-call via an optionalcacheTtlMsparameter.createSorokitClientpassesconfig.cachethrough toestimateFee, so any client configured with a cache automatically benefits.Changes
src/shared/constants.tsDEFAULT_FEE_CACHE_TTL_MS = 300_000src/transaction/estimateFee.tscache?+cacheTtlMs?params; SHA256 key; cache get/set around simulationsrc/client/createSorokitClient.tsconfig.cachetoestimateFeesrc/tests/transaction.test.tsTest plan
FeeEstimatewithout callingsimulateTransactioncache.get()returningundefinedtriggers fresh simulationcache.set()called withDEFAULT_FEE_CACHE_TTL_MS(300000 ms)cache.set()called with caller-provided TTL