MMF-4124 Download CFamily analyzer on demand #689
+346
−159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jblievremont
force-pushed
the
MMF-4124-cfamily-on-demand
branch
3 times, most recently
from
6753381 to
b730d0e
Compare
jblievremont
force-pushed
the
MMF-4124-cfamily-on-demand
branch
2 times, most recently
from
8427df0 to
34efc72
Compare
jblievremont
force-pushed
the
MMF-4124-cfamily-on-demand
branch
from
34efc72 to
7a29948
Compare
jblievremont
commented
Feb 21, 2025
| @@ -33,7 +32,8 @@ export async function deployBuildInfo() { | |||
| const response = await fetch(`${process.env.ARTIFACTORY_URL}/api/build`, { | |||
| method: 'PUT', | |||
| body, | |||
| headers | |||
| headers, | |||
| duplex: 'half' | |||
There was a problem hiding this comment.
This new parameter was required by the move to the Node built-in fetch
|
|
||
| const HTTP_BAD_REQUEST = 400; | ||
|
|
||
| export async function downloadFile(fileUrl, destPath, useAuthentication=false) { |
There was a problem hiding this comment.
Extracted to a dedicated util module since both the JRE and O# download rely on it.
Comment on lines
+21
to
+23
| const fileReadStream = Readable.toWeb(createReadStream(`./${file}`)); | ||
| const signature = await sign(fileReadStream, opts.privateKeyArmored, opts.passphrase); | ||
| writeFileSync(`./${file}.asc`, signature.toString(), 'ascii'); |
There was a problem hiding this comment.
Required by the upgrade of the openpgp library.
| @@ -0,0 +1,64 @@ | |||
| -----BEGIN PGP PUBLIC KEY BLOCK----- | |||
There was a problem hiding this comment.
This file could be downloaded from a trusted source at build time, but since it's static (and small) we can also copy it here.
| @@ -31,6 +31,7 @@ const config = { | |||
| vscode: 'commonjs vscode' | |||
| }, | |||
| resolve: { | |||
| mainFields: ['browser', 'module', 'main'], | |||
There was a problem hiding this comment.
New recommendation from the VSCode bundling guide.
|
sophio-japharidze-sonarsource
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MMF-4124
MMF-4124