Align Gantt behavior with supported surface - #27
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6cab2bd72b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| th.appendChild(document.createTextNode(col.label)); | ||
| th.appendChild(sf.el('span', { className: 'sort-icon' }, isCurrent ? (sortState.direction === 'asc' ? '▲' : '▼') : '')); | ||
|
|
||
| sf.bindActivation(th, function () { |
There was a problem hiding this comment.
Any integration that follows the new README and sets sortable: true will fail here during setTasks(): I searched the repo and there is no sf.bindActivation implementation in either js-src or the built static/sf/sf.js, so buildHeaderCell() throws before the grid renders. That makes the newly added sortable-column path unusable until this is replaced with a real event binding or the helper is added.
Useful? React with 👍 / 👎.
6cab2bd to
b323315
Compare
1 participant
Closes #9.\n\n## Summary\n- add opt-in sortable Gantt grid headers driven by columns\n- wire pinned tasks through to Frappe custom classes so pinned styling actually renders\n- remove leftover CSS hooks for unsupported maximize, drag tooltip, project badge, and cross-project arrow behavior\n- update README examples to describe only the shipped Gantt feature set\n