Skip to content

Conversation

jim-bcom
Copy link
Contributor

@jim-bcom jim-bcom commented Jun 21, 2023

Project goes rom 200+ warnings to 7 due to tools and third parties, 0 warning on project sources.

  • remove unused parameters warnings by commenting the parameter name
  • remove reorder warning by matching init order with declaration order
  • remove make "jobserver unavailable" warning by using $(MAKE) i.o. make in .pro file
  • fixed actual issues (e.g. missing return statement)
  • also uses XPCF MACROs for attributes so that we can disable them at once and remove GCC warnings on ignored atributes.

@jim-bcom jim-bcom self-assigned this Jun 21, 2023
Project goes rom 200+ warnings to 7 due to tools and third parties, 0 warning on
project sources.

- remove unused parameters warnings by commenting the parameter name
- remove reorder warning by matching init order with declaration order
- remove make "jobserver unavailable" warning by using $(MAKE) i.e. make in .pro file
- fixed actual issues (e.g. missing return statement)
- also uses XPCF MACROs for attributes so that we can disable them at once and remove GCC
warnings on ignored atributes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant