This repository was archived by the owner on Jul 20, 2023. It is now read-only.
Use relative URLs for submodules #16
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, committed URLs are HTTPS. This requires the use of a token and frequent use of credentials. SSH URLs on the other hand allows a more convenient workflow. We could convert all URLs to ssh instead, but then it becomes inconsistent if someone clones SolAR in HTTPS (e.g. for read only purpose), and don't want to configure SSH keys. The solution is to use relative path, as described here: https://www.damirscorner.com/blog/posts/20210423-ChangingUrlsOfGitSubmodules.html This way, the submodule will be fetched with whatever method used to clone SolAR. This may lead to ssh errors when 'git submodule foreach' is used with commands demanding a connection to the server (fetch, pull, ...). A solution is to increase 'MaxStartups' in sshd config as described here: https://docs.gitlab.com/ee/topics/git/troubleshooting_git.html#ssh_exchange_identification-error
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, committed URLs are HTTPS.
This requires the use of a token and frequent use
of credentials.
SSH URLs on the other hand allows a more convenient workflow.
We could convert all URLs to ssh instead, but then it becomes
inconsistent if someone clones SolAR in HTTPS (e.g. for read only
purpose), and don't want to configure SSH keys.
The solution is to use relative path, as described here:
https://www.damirscorner.com/blog/posts/20210423-ChangingUrlsOfGitSubmodules.html
This way, the submodule will be fetched with whatever method used
to clone SolAR.
This may lead to ssh errors when 'git submodule foreach' is used with
commands demanding a connection to the server (fetch, pull, ...).
A solution is to increase 'MaxStartups' in sshd config as described here:
https://docs.gitlab.com/ee/topics/git/troubleshooting_git.html#ssh_exchange_identification-error