-
Notifications
You must be signed in to change notification settings - Fork 61
chore(DATAGO-117300): update node version to 24.11.1 #540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
WhiteSource Policy Violation Summary✅︎ No Blocking Whitesource Policy Violations found in solaceai/solace-agent-mesh-ui-pr-540! |
| "lib": ["ES2023", "DOM", "DOM.Iterable"], | ||
| "downlevelIteration": true, | ||
| "skipLibCheck": true, | ||
| "types": ["node"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Limiting the types being installed.
... different build targets need different type definitions:
- The app build doesn't need any `@types` packages (uses only DOM and ES2023 types)
- The library build needs Node.js types for `NodeJS.Timeout`
- The Vite config needs Node.js types for build tooling
|
JKaram
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could write a .nvmrc file that includes the node version we are using. The CI/CD pipeline could use it so we don't have mismatch again.
Yep, we could add one - although I believe the engine specification in the package.json will do the same thing. I will re-test and make sure. Cheers! |





This pull request updates the Node.js version requirement across the project to ensure consistency and compatibility with the latest features and dependencies. It also makes minor adjustments to TypeScript configuration files to clarify type resolution and improve type safety.
Node.js version updates:
>=24.11.1 <25.0.0in all relevant documentation and configuration files, includingDockerfile,README.md,cypress/README.md, and bothpackage.jsonfiles for the frontend and config portal. [1] [2] [3] [4] [5]TypeScript configuration improvements:
typesandtypeRootsfields totsconfig.app.jsonandtsconfig.lib.jsonto clarify type resolution and avoid conflicts. [1] [2]typesto["node"]andtypeRootsto["./node_modules/@types"]intsconfig.node.jsonto ensure proper Node.js type definitions are used.Trying to install with node v25
Trying to install with node v20