Skip to content

Conversation

@lgh-solace
Copy link
Collaborator

@lgh-solace lgh-solace commented Nov 12, 2025

This pull request updates the Node.js version requirement across the project to ensure consistency and compatibility with the latest features and dependencies. It also makes minor adjustments to TypeScript configuration files to clarify type resolution and improve type safety.

Node.js version updates:

  • Updated Node.js version requirement to >=24.11.1 <25.0.0 in all relevant documentation and configuration files, including Dockerfile, README.md, cypress/README.md, and both package.json files for the frontend and config portal. [1] [2] [3] [4] [5]

TypeScript configuration improvements:

  • Added explicit types and typeRoots fields to tsconfig.app.json and tsconfig.lib.json to clarify type resolution and avoid conflicts. [1] [2]
  • Set types to ["node"] and typeRoots to ["./node_modules/@types"] in tsconfig.node.json to ensure proper Node.js type definitions are used.

Trying to install with node v25

npm warn EBADENGINE Unsupported engine {
npm warn EBADENGINE   package: '@SolaceLabs/[email protected]',
npm warn EBADENGINE   required: { node: '>=24.11.1 <25.0.0' },
npm warn EBADENGINE   current: { node: 'v25.2.0', npm: '11.6.2' }
npm warn EBADENGINE }

Trying to install with node v20

npm warn EBADENGINE Unsupported engine {
npm warn EBADENGINE   package: '@SolaceLabs/[email protected]',
npm warn EBADENGINE   required: { node: '>=24.11.1 <25.0.0' },
npm warn EBADENGINE   current: { node: 'v20.19.2', npm: '10.8.2' }
npm warn EBADENGINE }

@github-actions
Copy link

github-actions bot commented Nov 12, 2025

WhiteSource Policy Violation Summary

✅︎ No Blocking Whitesource Policy Violations found in solaceai/solace-agent-mesh-ui-pr-540!

@lgh-solace lgh-solace changed the title DO NOT MERGE: node update to 24.11.1 chore(DATAGO-117300): update node version to 24.11.1 Nov 12, 2025
"lib": ["ES2023", "DOM", "DOM.Iterable"],
"downlevelIteration": true,
"skipLibCheck": true,
"types": ["node"],
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Limiting the types being installed.

... different build targets need different type definitions:

- The app build doesn't need any `@types` packages (uses only DOM and ES2023 types)
- The library build needs Node.js types for `NodeJS.Timeout`
- The Vite config needs Node.js types for build tooling

@sonarqube-solacecloud
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

Copy link
Contributor

@JKaram JKaram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could write a .nvmrc file that includes the node version we are using. The CI/CD pipeline could use it so we don't have mismatch again.

@lgh-solace
Copy link
Collaborator Author

We could write a .nvmrc file that includes the node version we are using. The CI/CD pipeline could use it so we don't have mismatch again.

Yep, we could add one - although I believe the engine specification in the package.json will do the same thing. I will re-test and make sure. Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants