Individual vesting schedule by start, end, and cliff #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackdishman
changed the title
jackdishman
force-pushed
the
per-address-randall-jack
branch
from
1fb2365 to
200c103
Compare
ranleung
reviewed
Feb 27, 2024
| // SPDX-License-Identifier: MIT | ||
| pragma solidity ^0.8.0; | ||
|
|
||
| contract TrancheVesting { |
There was a problem hiding this comment.
The file name is GeneratePeriodicTranches.sol, i wonder if we should update the contract name to match the file name? PeriodicTranches maybe?
ranleung
reviewed
Feb 27, 2024
| // re-initialize if the total has been updated | ||
| _initializeDistributionRecord(beneficiary, totalAmount, _start, _end, _cliff); | ||
| } | ||
| if(records[beneficiary].start != _start || records[beneficiary].end != _end || records[beneficiary].cliff != _cliff) { |
There was a problem hiding this comment.
i'm thinking about if we need to combine both if blocks. There could be a time where records total and records start/end/cliff doesn't match. If that's the case, two distribution records are created.
if (records[beneficiary].total != totalAmount || records[beneficiary].start != _start || records[beneficiary].end != _end || records[beneficiary].cliff != _cliff) {
_initializeDistributionRecord(beneficiary, totalAmount, _start, _end, _cliff);
}```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.