Conversation
arthcp
requested changes
Feb 25, 2025
Comment on lines
152
to
161
| function resolveTimeout( | ||
| bytes32 timeoutId_, | ||
| uint256 signatureNonce_, | ||
| bytes calldata signature_ | ||
| ) external { | ||
| _isWatcherSignatureValid( | ||
| signatureNonce_, | ||
| keccak256(abi.encode(address(this), evmxChainSlug, signatureNonce_, timeoutId_)), | ||
| signature_ | ||
| ); |
Contributor
There was a problem hiding this comment.
we need to add expected function call (resolveTimeout) to digest. This will help block signature reuse on other functions if they have similar params.
Comment on lines
152
to
161
| function resolveTimeout( | ||
| bytes32 timeoutId_, | ||
| uint256 signatureNonce_, | ||
| bytes calldata signature_ | ||
| ) external { | ||
| _isWatcherSignatureValid( | ||
| signatureNonce_, | ||
| keccak256(abi.encode(address(this), evmxChainSlug, signatureNonce_, timeoutId_)), | ||
| signature_ | ||
| ); |
Contributor
There was a problem hiding this comment.
The structure of digests is not enforced. i.e. there is no mechanism to make sure each digest has address, evmxSlug and nonce. lets enforce this somehow.
arthcp
previously approved these changes
Feb 25, 2025
arthcp
approved these changes
Feb 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.