-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: replace resolver-oxc
with new resolver-typescript
#386
Conversation
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/[email protected] |
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/[email protected] |
🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎ To accept the risk, merge this PR and you will not be notified again.
Next stepsWhat are unpopular packages?This package is not very popular. Unpopular packages may have less maintenance and contain other problems. Take a deeper look at the dependencyTake a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev. Remove the packageIf you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency. Mark a package as acceptable riskTo ignore an alert, reply with a comment starting with
|
Actually, rules like |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @JounQin. Holding for more thorough review.
…esolver-typescript`
ab70f30
to
21f254c
Compare
@jdalton By the way, I have troubles when running socket-cli on chore/import_resolver ❯ npmR bs
> [email protected] bs
> npm run build:dist; npm exec socket --
> [email protected] build:dist
> del-cli 'dist' && rollup -c .config/rollup.dist.config.mjs
/Users/JounQin/Workspaces/GitHub/socket-cli/src/cli.ts, /Users/JounQin/Workspaces/GitHub/socket-cli/src/constants.ts, /Users/JounQin/Workspaces/GitHub/socket-cli/src/shadow/npm/bin.ts, /Users/JounQin/Workspaces/GitHub/socket-cli/src/shadow/npm/inject.ts → dist/module-sync...
created dist/module-sync in 5.3s
/Users/JounQin/Workspaces/GitHub/socket-cli/src/cli.ts, /Users/JounQin/Workspaces/GitHub/socket-cli/src/constants.ts, /Users/JounQin/Workspaces/GitHub/socket-cli/src/shadow/npm/bin.ts, /Users/JounQin/Workspaces/GitHub/socket-cli/src/shadow/npm/inject.ts → dist/require...
created dist/require in 4.9s
node:internal/modules/cjs/loader:1397
throw err;
^
{
code: 'MODULE_NOT_FOUND',
requireStack: [
'/Users/JounQin/Workspaces/GitHub/socket-cli/node_modules/@pnpm/lockfile-file/lib/logger.js',
'/Users/JounQin/Workspaces/GitHub/socket-cli/node_modules/@pnpm/lockfile-file/lib/write.js',
'/Users/JounQin/Workspaces/GitHub/socket-cli/node_modules/@pnpm/lockfile-file/lib/index.js',
'/Users/JounQin/Workspaces/GitHub/socket-cli/dist/module-sync/cli.js'
]
}
Node.js v23.7.0 OK, should be related to Node v23 only because it tries |
Updated independently. Thank you @JounQin! |
Hi,
eslint-plugin-import-x
andeslint-import-resolver-typescript
owner here.The brand new
eslint-import-resolver-typescript
is now powered by unrs-resolver which is fork of oxc-resolver and rspack-resolver with P'n'P support and more targets, and it has competitive performance compared witheslint-import-resolver-oxc
.Before with
resolver-oxc
:After with
resolver-typescript
: