fix: preserve whitespace chunks in stream to fix markdown heading rendering#488
Open
Salman-Ahamed wants to merge 1 commit intodevfrom
Open
fix: preserve whitespace chunks in stream to fix markdown heading rendering#488Salman-Ahamed wants to merge 1 commit intodevfrom
Salman-Ahamed wants to merge 1 commit intodevfrom
Conversation
- Updated the hasContent check to ensure it correctly validates the presence of content by checking for null values, enhancing error handling and robustness of the function.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 What’s this PR about?
Fixes markdown headings rendering as plain text in Chat/Chatbot UIs.
Root cause:
parseChunk()used.trim()to validate content, which silentlydropped whitespace-only chunks (e.g.,
\n\n). This caused headings to glueto previous text (e.g.,
Q2## Executive Summary), preventing react-markdownfrom parsing them as headings.
Fix: Changed
hasContentcheck fromchunk.content.trim() !== ''tochunk.content !== ''so newline chunks are preserved in the stream output.📎 Related ClickUp Ticket
💻 Demo (optional)
✅ Checklist