-
Notifications
You must be signed in to change notification settings - Fork 195
Add xx_input_method_v1 support. #1745
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
To test:
|
This is an implementation of https://gitlab.freedesktop.org/wayland/wayland-protocols/-/merge_requests/407 |
Lookng at CI failures, I need some help understanding what they are. For example, this code wasn't even touched by my change.
There's also the ack_configure callback which is for some reason exposed to the compositor, but I don't really understand why, so I couldn't come up with a sensible doc comment. |
I think that's a result of the earlier warning. Because certain methods are never used, the variables that are read only in those methods are never read. |
Added repositioning:
Screencast_20250524_202116.webm |
335ccb6
to
9497a8f
Compare
I did some cleanups:
Is there anything I can do to make reviewing this easier? |
src/desktop/wayland/popup/mod.rs
Outdated
} | ||
} | ||
|
||
fn send_done(&self) { | ||
match *self { | ||
PopupKind::Xdg(ref t) => t.send_popup_done(), | ||
PopupKind::InputMethod(_) => {} //Nothing to do the IME takes care of this itself | ||
PopupKind::InputMethodV3(_) => {} //Nothing to do the IME takes care of this itself |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This might be useful as a way to communicate that the compositor closed the popup? Or is it redundant since normally that would follow from a deactivate?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was nothing to do previously since there was no concept of how the popup should function. But you are free to add that now if it is needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, the only time the compositor closes the popup is in deactivate, so I decided there's no need for another notification. Would one be useful?
run these on your branch and correct them btw: |
LGTM otherwise, someone that knows xdg positioner should probably have a look at the positioner and popup part |
The only thing left that breaks ci is the ack_configure which I have no idea what to do with. |
Just add documentation to this function:
|
Well that's the problem, I don't have a clue what it's meant to do :P I copy-pasted it without understanding and I hope a reviewer can enlighten me. |
Implements https://gitlab.freedesktop.org/wayland/wayland-protocols/-/merge_requests/407
Notably missing: repositioning, reactivity of the popup.EDIT: this replaces the previous input method for now, so I made it a draft instead.