Add UNIX socket support for redis session store #58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds unix socket option for redis session store. Using the option requires that both redis_host and redis_port should be None. If no unix socket is supplied, the behavior doesn't change at all. This commit can be applies to both branches 11.0 and 12.0 as is.
|
Closing the PR for now. This commit is missing a check that the port value is not None before trying to convert port value to integer. |
|
The temporary fix works for our testing environment, you'll probably want to come up with something more sophisticated though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds unix socket option for redis session store. Using the option requires that both redis_host and redis_port should be None. If no unix socket is supplied, the behavior doesn't change at all. This commit can be applies to both branches 11.0 and 12.0 as is.
This is one possible solution to issue #56