Skip to content

Conversation

NoahCornell
Copy link
Contributor

Check all that apply

Type of Change

  • WWST Certification Request
    • If this is your first time contributing code:
      • I have reviewed the README.md file
      • I have reviewed the CODE_OF_CONDUCT.md file
      • I have signed the CLA
    • I plan on entering a WWST Certification Request or have entered a request through the WWST Certification console at developer.smartthings.com
  • Bug fix
  • New feature
  • Refactor

Checklist

  • I have performed a self-review of my code
  • I have commented my code in hard-to-understand areas
  • I have verified my changes by testing with a device or have communicated a plan for testing
  • I am adding new behavior, such as adding a sub-driver, and have added and run new unit tests to cover the new behavior

Description of Change

There are some errors popping up after the latest sonos driver release to beta due to the players in the groups response not containing the field devices. Fortunately, all we care about are the IDs of these devices and the players should also have a field deviceIds.

The sonos docs are not very clear because both deviceIds and devices are shown as deprecated. However, deviceIds and other fields reference that you should be using the devices array. There is also a query parameter that you can use to include the device info but that doesn't appear to do anything from my testing.

https://docs.sonos.com/reference/groups-getgroups-householdid

Summary of Completed Tests

Testing on my two play:3 and Sonos One all on the latest firmware, both fields deviceIds and devices are available. I have tested that using either field will work for tracking the bonded set. I have not been able to reproduce where the devices is missing. It looks like this will happen if the sonos device is on an older firmware.

Copy link

github-actions bot commented Sep 17, 2025

Channel deleted.

Copy link

github-actions bot commented Sep 17, 2025

Test Results

   70 files    451 suites   0s ⏱️
2 344 tests 2 344 ✅ 0 💤 0 ❌
3 949 runs  3 949 ✅ 0 💤 0 ❌

Results for commit dad0368.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Sep 17, 2025

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against dad0368

@NoahCornell NoahCornell merged commit b4644bd into main Sep 22, 2025
11 checks passed
@NoahCornell NoahCornell deleted the fix/sonos-nil-index branch September 22, 2025 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants