Skip to content

Required changes in the driver for Door/Window Contact II [M] device #2061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

JanJakubiszyn
Copy link
Contributor

@JanJakubiszyn JanJakubiszyn commented Apr 10, 2025

Check all that apply

Type of Change

  • WWST Certification Request
    • If this is your first time contributing code:
      • I have reviewed the README.md file
      • I have reviewed the CODE_OF_CONDUCT.md file
      • I have signed the CLA
    • I plan on entering a WWST Certification Request or have entered a request through the WWST Certification console at developer.smartthings.com
  • Bug fix
  • New feature
  • Refactor

Checklist

  • I have performed a self-review of my code
  • I have commented my code in hard-to-understand areas
  • I have verified my changes by testing with a device or have communicated a plan for testing
  • I am adding new behavior, such as adding a sub-driver, and have added and run new unit tests to cover the new behavior

Description of Change

Creating a sub-driver which handles button functionality for Bosch Door/Window Contact II [M] device.

Summary of Completed Tests

Manual tests of button capability.

@JanJakubiszyn JanJakubiszyn changed the title Mater sensor and bosch-button-contact cleanup + fingerprint Required changes in the driver for Door/Window Contact II [M] device Apr 10, 2025
@JanJakubiszyn
Copy link
Contributor Author

Hi @greens , I have implemented the required changes from the previous PR.

#2055

Copy link

Duplicate profile check: Passed - no duplicate profiles detected.

Copy link

github-actions bot commented Apr 10, 2025

Channel deleted.

Copy link

github-actions bot commented Apr 10, 2025

Test Results

   66 files    422 suites   0s ⏱️
2 171 tests 2 171 ✅ 0 💤 0 ❌
3 694 runs  3 694 ✅ 0 💤 0 ❌

Results for commit fd71be1.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Apr 10, 2025

File Coverage
All files 84%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-sensor/src/bosch-button-contact/init.lua 44%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-sensor/src/smoke-co-alarm/init.lua 83%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-sensor/src/air-quality-sensor/init.lua 92%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-sensor/src/embedded-cluster-utils.lua 45%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-sensor/src/init.lua 91%

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against fd71be1

@KKlimczukS KKlimczukS requested review from greens and removed request for greens April 14, 2025 12:23
@nickolas-deboom
Copy link
Contributor

Has this been tested with the device?

@JanJakubiszyn JanJakubiszyn force-pushed the WWSTCERT-5977_support_for_button branch from 1512ec8 to ce00a11 Compare April 15, 2025 12:48
@JanJakubiszyn
Copy link
Contributor Author

Hi @nickolas-deboom , I have cleaned up the main init file for matter-sensor driver as per Your instructions.

Device was tested manually and no issues were raised.

@nickolas-deboom
Copy link
Contributor

Hi @nickolas-deboom , I have cleaned up the main init file for matter-sensor driver as per Your instructions.

Device was tested manually and no issues were raised.

Thank you, I also noticed one more issue and left an additional comment.

@JanJakubiszyn JanJakubiszyn force-pushed the WWSTCERT-5977_support_for_button branch from 10aecc1 to dfc51c6 Compare April 16, 2025 12:33
@hcarter-775
Copy link
Contributor

make sure to squash the commits before merging, thanks!

@KKlimczukS KKlimczukS merged commit 448a193 into SmartThingsCommunity:main Apr 16, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants