Skip to content

[STSE-3818] Feature(matter-lock) Add eufy lock products to new-matter-lock driver #2059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 15, 2025
Merged

[STSE-3818] Feature(matter-lock) Add eufy lock products to new-matter-lock driver #2059

merged 1 commit into from
Apr 15, 2025

Conversation

HunsupJung
Copy link
Collaborator

Type of Change

  • WWST Certification Request
    • If this is your first time contributing code:
      • I have reviewed the README.md file
      • I have reviewed the CODE_OF_CONDUCT.md file
      • I have signed the CLA
    • I plan on entering a WWST Certification Request or have entered a request through the WWST Certification console at developer.smartthings.com
  • Bug fix
  • New feature
  • Refactor

Checklist

  • I have performed a self-review of my code
  • I have commented my code in hard-to-understand areas
  • I have verified my changes by testing with a device or have communicated a plan for testing
  • I am adding new behavior, such as adding a sub-driver, and have added and run new unit tests to cover the new behavior

Description of Change

https://smartthings.atlassian.net/browse/STSE-3818

Summary of Completed Tests

@HunsupJung
Add eufy lock products to new-matter-lock driver
63d9528 
- FamiLock S3 Max
- FamiLock S3
- FamiLock E34
- FamiLock E35

Signed-off-by: Hunsup Jung <[email protected]>
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 10, 2025 •
edited
Loading

Channel deleted.

@github-actions GitHub Actions
Copy link

Test Results

   66 files    421 suites   0s ⏱️
2 166 tests 2 166 ✅ 0 💤 0 ❌
3 688 runs  3 688 ✅ 0 💤 0 ❌

Results for commit 63d9528.

@github-actions GitHub Actions
Copy link

File Coverage
All files 91% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-lock/src/lock_utils.lua 98% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-lock/src/init.lua 91% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-lock/src/new-matter-lock/init.lua 90% ✅

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against 63d9528

@Kwang-Hui
Copy link
Contributor

cc: @Brianj94

@HunsupJung HunsupJung requested a review from hcarter-775 April 11, 2025 10:15
Kwang-Hui
Kwang-Hui approved these changes Apr 15, 2025
View reviewed changes
Copy link
Contributor

@Kwang-Hui Kwang-Hui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@HunsupJung HunsupJung merged commit 0eb0a50 into main Apr 15, 2025
11 checks passed
@HunsupJung HunsupJung deleted the feature/add-eufy-products-to-new-matter-lock-driver branch April 15, 2025 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kwang-Hui Kwang-Hui Kwang-Hui approved these changes

@hcarter-775 hcarter-775 hcarter-775 approved these changes

@lelandblue lelandblue Awaiting requested review from lelandblue

@tpmanley tpmanley Awaiting requested review from tpmanley

@nickolas-deboom nickolas-deboom Awaiting requested review from nickolas-deboom

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HunsupJung @Kwang-Hui @hcarter-775