Skip to content

[FP2] apply necessary modifications and improvements #2058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 23, 2025

Conversation

hdlee27
Copy link
Contributor

@hdlee27 hdlee27 commented Apr 10, 2025

Check all that apply

Type of Change

  • WWST Certification Request
    • If this is your first time contributing code:
      • I have reviewed the README.md file
      • I have reviewed the CODE_OF_CONDUCT.md file
      • I have signed the CLA
    • I plan on entering a WWST Certification Request or have entered a request through the WWST Certification console at developer.smartthings.com
  • Bug fix
  • New feature
  • Refactor

Checklist

  • I have performed a self-review of my code
  • I have commented my code in hard-to-understand areas
  • I have verified my changes by testing with a device or have communicated a plan for testing
  • I am adding new behavior, such as adding a sub-driver, and have added and run new unit tests to cover the new behavior

Description of Change

apply necessary modifications and improvements for new fp2 firmware

  • Token initialization function is added to new firmware. Exception handling is added for when tokens for already registered devices are invalidated.
  • Add the time information log received from fp2 of the important event
  • Check whether the device is registered again for cases where there are many devices on the same network.
  • Modify the driver not to shut down too early for remove processing when removing the device
  • Other inefficient code improvement

Summary of Completed Tests

hdlee27 added 6 commits April 10, 2025 08:27
If there are many fp2 devices in the network, the waiting time increases,
and the device added during waiting is attempted to re-register.

To prevent this problem, check whether it is registered again.

Signed-off-by: hdlee27 <[email protected]>
Copy link

github-actions bot commented Apr 10, 2025

Channel deleted.

Copy link

github-actions bot commented Apr 10, 2025

Test Results

   66 files    422 suites   0s ⏱️
2 171 tests 2 171 ✅ 0 💤 0 ❌
3 694 runs  3 694 ✅ 0 💤 0 ❌

Results for commit 7f2adf8.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Apr 10, 2025

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against 7f2adf8

@varzac varzac merged commit 9169d5a into SmartThingsCommunity:main Apr 23, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants