Skip to content

TC-109088 preflight check and treat no log as error #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kapi-smartbear wants to merge 3 commits into
base: master
Choose a base branch
from
Open

TC-109088 preflight check and treat no log as error #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
38e7d60
Made sure we treat no log file as error and we do a fast exit if no p…
kapi-smartbear Oct 1, 2025
ea161b2
Update pom.xml
kapi-smartbear Oct 1, 2025
d226d20
Made sure the path works if it is relative
kapi-smartbear Nov 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@

<properties>
<jenkins.version>2.361.4</jenkins.version>
<java.version>11</java.version>
</properties>

<artifactId>TestComplete</artifactId>
Expand Down
16 changes: 14 additions & 2 deletions src/main/java/com/smartbear/jenkins/plugins/testcomplete/TcTestBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -685,6 +685,9 @@ public void performInternal(Run<?, ?> run, FilePath filePath, Launcher launcher,

boolean useSessionCreator = chosenInstallation.hasExtendedCommandLine() && (!needToUseService);

TcLog.info(listener, "Log file: %s", workspace.getMasterLogXFilePath().getName());


// Making the command line
List<String> passwordsToMask = new ArrayList<>();
ArgumentListBuilder args = makeCommandLineArgs(run, launcher, listener, workspace, chosenInstallation, useSessionCreator, passwordsToMask);
Expand Down Expand Up @@ -723,6 +726,15 @@ public void performInternal(Run<?, ?> run, FilePath filePath, Launcher launcher,
}
}

//Prefilight check, check if project file exists
FilePath projectFile = new FilePath(workspace.getSlaveWorkspacePath(), env.expand(getSuite()));
if(!projectFile.exists() || projectFile.isDirectory()) {
TcLog.error(listener, Messages.TcTestBuilder_UnableToFindProjectFile(), projectFile.getRemote());
run.setResult(Result.FAILURE);
return;
}


// TC/TE launching and data processing
TcReportAction tcReportAction = Optional.ofNullable(filePath)
.map(fpath -> fpath.toComputer())
Expand Down Expand Up @@ -1113,9 +1125,9 @@ private void processFiles(TcInstallation installation, Run<?, ?> run, VirtualCha
}
}
else {
TcLog.warning(listener, Messages.TcTestBuilder_UnableToFindLogFile(),
TcLog.error(listener, Messages.TcTestBuilder_UnableToFindLogFile(),
workspace.getSlaveLogXFilePath().getName());

run.setResult(Result.FAILURE);
testResult.setLogInfo(new TcLogInfo(startTime, 0, 0, 1, 0));
}

Expand Down
1 change: 1 addition & 0 deletions src/main/resources/com/smartbear/jenkins/plugins/testcomplete/Messages.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ TcTestBuilder.NotWindowsOS = TestComplete/TestExecute can be launched only on th
TcTestBuilder.InvalidTimeoutValue = Invalid timeout value: "%s". The default timeout will be used.
TcTestBuilder.InstallationNotFound = Unable to find the specified TestComplete/TestExecute installation.

TcTestBuilder.UnableToFindProjectFile = Unable to find the project file "%s".
TcTestBuilder.UnableToFindLogFile = Unable to find the log file "%s".
TcTestBuilder.ErrorMessage = Error: %s.
TcTestBuilder.RemoteCallingFailed = An error occurred while executing code on the test machine (slave): %s.
Expand Down