feat: Limit ftplugin to buffer and avoid early lua requires #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Slotos
force-pushed
the
skip-filesystem-lookups-and-stay-in-buffer-ftplugin
branch
3 times, most recently
from
d1fdcab to
ca37ca0
Compare
This changes ftplugin behaviour to: - create user commands confined to the buffer it was triggered on - avoid filesystem lookups of require (they add up) by postponing them until user command gets invoked - skip loading if it has already been executed in a buffer To deduplicate ftplugins, lua's `dofile` is used to load a specific file that holds all shared commands. This is equivalent to vimscript standard `source` approach. These make ftplugin portion of this plugin behave like a good neighbor ftplugin - its changes are buffer local, as it's invoked when a buffer filetype matches. Additionally, ftplugins now read global `disable_typescript_tools` variable, returning early if it's set. Not a common behaviour for ftplugins in general, but a good way to give users fine control over plugin behaviour nonetheless. Not tackled is cleanup in case buffer filetype changes without reloading. I don't think routines for that currently exists, in fact.
Slotos
force-pushed
the
skip-filesystem-lookups-and-stay-in-buffer-ftplugin
branch
from
ca37ca0 to
d0d8bfa
Compare
This fixes nightly test failures. This also changes behaviour in complex scenarios most likely, as instead of matching just the last node, we now consider all nodes in the match.
Slotos
force-pushed
the
skip-filesystem-lookups-and-stay-in-buffer-ftplugin
branch
from
9284003 to
35e5ce5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes ftplugin behaviour to:
To deduplicate ftplugins, lua's
dofileis used to load a specific file that holds all shared commands. This is equivalent to vimscript standardsourceapproach.These make ftplugin portion of this plugin behave like a good neighbor ftplugin - its changes are buffer local, as it's invoked when a buffer filetype matches.
Additionally, ftplugins now read global
disable_typescript_toolsvariable, returning early if it's set. Not a common behaviour for ftplugins in general, but a good way to give users fine control over plugin behaviour nonetheless.Not tackled is cleanup in case buffer filetype changes without reloading. I don't think routines for that currently exists, in fact.