Skip to content

Conversation

@m1919810
Copy link

简介

相关的 Issues (没有可不填)

快速修复一下 尽快合并

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR replaces all usages of Apache Commons Lang's Validate class with Guava's Preconditions class throughout the codebase and removes the Apache Commons Lang dependency. The change maintains equivalent validation behavior while standardizing on Guava's precondition checks.

Key changes:

  • Replaced Validate.notNull() with Preconditions.checkNotNull()
  • Replaced Validate.isTrue() with Preconditions.checkArgument()
  • Replaced Validate.notEmpty() with length/size checks combined with Preconditions.checkArgument()
  • Replaced Validate.noNullElements() with explicit loops checking each element
  • Removed Apache Commons Lang dependency from pom.xml
  • Added internal implementations of Apache Commons Lang exception classes (Nestable, NestableDelegate, ExceptionUtils, NotImplementedException, Validate) for backward compatibility

Reviewed changes

Copilot reviewed 125 out of 126 changed files in this pull request and generated no comments.

Show a summary per file
File Description
pom.xml Removed Apache Commons Lang dependency and its relocation configuration
Multiple Java files Replaced Validate calls with Preconditions throughout the codebase
BlockDataConfigWrapper.java Updated import to use internal NotImplementedException
libraries/commons/lang/*.java Added internal compatibility implementations for Apache Commons Lang classes
.gitignore Added /scripts/ directory to gitignore

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@StarWishsama
Copy link
Member

Closes by 08e0758

@StarWishsama StarWishsama reopened this Dec 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants