Conversation
We don't need to do this as from what i see Lines 287 to 292 in baf2d79 And spigot already auto renames these fields for plugins that are built for older minecraft versions: https://hub.spigotmc.org/stash/projects/SPIGOT/repos/craftbukkit/browse/src/main/java/org/bukkit/craftbukkit/legacy/FieldRename.java . So no error will be thrown. |
|
This pr conflicts with #219. |
This does need to be updated as otherwise dough cannot compile if the consumer is compiling against 1.20.5+. The suggested fix is to refactor it to use the bukkit |
|
Done |
There was a problem hiding this comment.
Java started using records in Java 16, while Authlib didn't use records until much later. As of the last version of Paper 1.18.2 that depended on Authlib, Property was still a class. Therefore, you might need to use reflection to call the getter method of an older version of Property.
fix: use old getter of property for older versions
ybw0014
left a comment
There was a problem hiding this comment.
Based on the result server testing by boomer:
dough-items/src/main/java/io/github/bakedlibs/dough/items/nms/ItemNameAdapterPaper.java
Show resolved
Hide resolved
The adapter is using adventure which was not bundled into Paper until 1.19.4 so to support it, we can only use this version or higher.
1b94fb1 to
66870dd
Compare
ea6c989 to
67f9cb9
Compare
Changes
PlayerHeadAdapterspom.xmlin moduledough-protectionbecause dough couldn't be compiled. This is because one of dependencies provided very old version of bukkit which broke compilationpom.xmlchanged from spigot to paper to be able to use paper features in adapters