Skip to content

Add SlicerOpenLIFU #2162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: 5.8
Choose a base branch
from
Open

Add SlicerOpenLIFU #2162

wants to merge 2 commits into from

Conversation

arhowe00
Copy link

@arhowe00 arhowe00 commented Apr 22, 2025

New extension

Tier 1

Any extension that is listed in the Extensions Catalog must fulfill these requirements.

  • Repository name is Slicer+ExtensionName (except if the repository that hosts the extension can be also used without Slicer)
  • Repository is associated with 3d-slicer-extension GitHub topic so that it is listed here. To edit topics, click the settings icon in the right side of "About" section header and enter 3d-slicer-extension in "Topics" and click "Save changes". To learn more about topics, read https://help.github.com/en/articles/about-topics
  • Extension description summarizes in 1-2 sentences what the extension is usable (should be understandable for non-experts)
  • Any known related patents must be mentioned in the extension description.
  • LICENSE.txt is present in the repository root and the name of the license is mentioned in extension homepage. We suggest you use a permissive license that includes patent and contribution clauses. This will help protect developers and ensure the code remains freely available. MIT (https://choosealicense.com/licenses/mit/) or Apache (https://choosealicense.com/licenses/apache-2.0/) license is recommended. Read here to learn more about licenses. If source code license is more restrictive for users than MIT, BSD, Apache, or 3D Slicer license then describe the reason for the license choice and include the name of the used license in the extension description.
  • Extension URL and revision (scmurl, scmrevision) is correct, consider using a branch name (main, release, ...) instead of a specific git hash to avoid re-submitting pull request whenever the extension is updated
  • Extension icon URL is correct (do not use the icon's webpage but the raw data download URL that you get from the download button - it should look something like this: https://raw.githubusercontent.com/user/repo/main/SomeIcon.png)
  • Screenshot URLs (screenshoturls) are correct, contains at least one
  • Content of submitted json file is consistent with the top-level CMakeLists.txt file in the repository (dependencies, etc. are the same)
  • Homepage URL points to valid webpage containing the following:
    • Extension name
    • Short description: 1-2 sentences, which summarizes what the extension is usable for
    • At least one nice, informative image, that illustrates what the extension can do. It may be a screenshot.
    • Description of contained modules: at one sentence for each module
    • Publication: link to publication and/or to PubMed reference (if available)
  • Hide unused github features (such as Wiki, Projects, and Discussions, Releases, Packages) in the repository to reduce noise/irrelevant information:
    • Click Settings and in repository settings uncheck Wiki, Projects, and Discussions (if they are currently not used).
    • Click the settings icon next to About in the top-right corner of the repository main page and uncheck Releases and Packages (if they are currently not used)
  • The extension is safe:
    • Does not include or download binaries from unreliable sources
    • Does not send any information anywhere without user consent (explicit opt-in is required)

Tier 3

Community-supported extensions.

  • Extension has a reasonable name (not too general, not too narrow, suggests what the extension is for)
  • Documentation, tutorial, and test data are provided for most modules. A tutorial provides step-by-step description of at least the most typical use case, include a few screenshots. Any sample data sets that is used in tutorials must be registered with the Sample Data module to provide easy access to the user.
  • Follows programming and user interface conventions of 3D Slicer (e.g., GUI and logic are separated, usage of popups is minimized, no unnecessary custom GUI styling, etc.)
  • The extension can be successfully built and packaged on all supported platforms (Windows, macOS, Linux)
  • Maintainers respond to issues and pull request submitted to the extension's repository.
  • Maintainers respond to questions directly addressed to him/her via @mention on the Slicer Forum.
  • Permissive license is used for the main functions of the extension (recommended Apache or MIT). The extension can provide additional functionality in optional components that are distributed with non-permissive license, but the user has to explicitly approve those before using them (e.g., a pop-up can be displayed that explains the licensing terms and the user has to acknowledge them to proceed).
  • All requirements of tiers < 3.

Tier 5

Critically important extensions, supported by Slicer core developers. New Slicer Stable Release is released only if all Tier 5 extension packages are successfully created on all supported platforms.

  • Slicer core developers accept the responsibility of fixing any issues caused by Slicer core changes; at least one Slicer core developer (anyone who has commit right to Slicer core) must be granted commit right to the extension's repository.
  • Automated tests for all critical features.
  • Maintainers respond to questions related to the extension on the Slicer Forum.
  • All requirements of tiers < 5.

An issue was opened regarding the variable set below in the root CMakeLists.txt:

set(EXTENSION_SCREENSHOTURLS "https://github.com/OpenwaterHealth/SlicerOpenLIFU/blob/main/Screenshots/1.png")

where Screenshots is supposed to be all lowercase as in the extension repository SlicerOpenLIFU.

@pieper
Copy link
Member

pieper commented Apr 22, 2025

Thanks for your work on this and interest in contributing.

We saw that the license for the code is AGPL, which we interpret as a "non-permissive" license, since it may require people to change the license on other code it's mixed with. So from a Slicer point of view, that would make this a "tier 1" extension. In the future we plan not to display tier 1 extensions by default.

I'd encourage you to try revisiting the license in order to collaborate more closely with the rest of the 3D Slicer community. There are many points of possible mutual benefit with projects like NousNav and SlicerTMS, but those collaborations won't be possible if you stick to the AGPL license. Please consider Apache 2.0, BSD, the Slicer License, or another option that would allow collaboration.

Also, just a comment on the readme: it would be good to include a definition of LIFU and also links to your company's website to make it easier for people to quickly understand what the project is about.

@ebrahimebrahim
Copy link

The license is a fixed choice by Openwater in this case and not likely to change. We could include a copyleft warning for anyone who tries to mix the extension into their own work. It would be convenient

Also, just a comment on the readme: it would be good to include a definition of LIFU and also links to your company's website to make it easier for people to quickly understand what the project is about.

Good idea. @arhowe00 here is some introductory text we could add:

Low intensity focused ultrasound (LIFU) is a method of neuromodulation. This uses ultrasound as a non-destructive treatment as opposed to using it for imaging.

This link to early access systems may be appropriate to include for now: https://www.openwater.health/early-access-systems

@arhowe00
Copy link
Author

Made these changes (including fixing the link) and posting a PR to SlicerOpenLIFU.

@arhowe00
Copy link
Author

Changes have been pushed to main @pieper

@lassoan
Copy link
Contributor

lassoan commented Apr 24, 2025

In medical image computing, permissive (MIT, Apache, BSD) licenses are the standard for open-source tools, probably because restrictive licenses practically prevent translating prototypes into clinical use. A restrictive license is acceptable in the Extensions Index, but to increase the impact of this extension and encourage community engagement, a permissive license would be a much better fit.

Would you be able to start a discussion with your funder about their open-source strategy and goals? They may find that the extreme AGPL license is not the best choice to achieve those goals. We would be happy to provide more details or participate in meetings if that helps.

@ebrahimebrahim
Copy link

The choice of AGPL seems to be quite deliberate, but it doesn't hurt to ask and I'm not actually sure it's non-negotiable or that nothing has changed since that choice was made. We can reach out and get back to you @lassoan and @pieper. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants