Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

system/realtek-bt: Align with template, respect $KERNEL. #6858

Closed
wants to merge 1 commit into from
Closed

system/realtek-bt: Align with template, respect $KERNEL. #6858

wants to merge 1 commit into from

Conversation

aclemons
Copy link
Collaborator

Packages for kernel modules on SBo should respect an env var KERNEL. This allows installing new kernel packages, then building packages for modules with the new version before rebooting, installing those and then rebooting into the new kernel. Then if desired, the duplicate packages can be removed when everything is working.

This also means the kernel version should be part of the package version so you can install a package for both kernels.

I've also adjusted the doinst.sh/douninst.sh to operate on the module from the package.

@aclemons
Copy link
Collaborator Author

@sbo-bot: build system/realtek-bt

@github-actions GitHub Actions
Copy link

reverse dependencies - system/realtek-bt

None

@github-actions GitHub Actions
Copy link

✅ sbolint - system/realtek-bt ✅

sbolint: realtek-bt checks out OK

@sbo-bot sbo-bot

This comment was marked as outdated.

Sign in to view
@sbo-bot sbo-bot

This comment was marked as outdated.

Sign in to view
@aclemons
system/realtek-bt: Align with template, respect $KERNEL.
5c16668 
Packages for kernel modules on SBo should respect an env var KERNEL.
This allows installing new kernel packages, then building packages
for modules with the new version before rebooting, installing those
and then rebooting into the new kernel. Then if desired, the
duplicate packages can be removed when everything is working.

This also means the kernel version should be part of the package
version so you can install a package for both kernels.

I've also adjusted the doinst.sh/douninst.sh to operate on the
module from the package.

Signed-off-by: Andrew Clemons <[email protected]>
@sbo-bot sbo-bot

This comment was marked as outdated.

Sign in to view
@sbo-bot sbo-bot

This comment was marked as outdated.

Sign in to view
@aclemons
Copy link
Collaborator Author

@sbo-bot: build system/realtek-bt

@github-actions GitHub Actions
Copy link

reverse dependencies - system/realtek-bt

None

@github-actions GitHub Actions
Copy link

✅ sbolint - system/realtek-bt ✅

sbolint: realtek-bt checks out OK

@aclemons aclemons mentioned this pull request Jun 23, 2024
Closed
@sbo-bot sbo-bot
Copy link

sbo-bot bot commented Jun 23, 2024

buildpkg i586 system/realtek-bt

Creating hintfile directory: /etc/repo/SBo/hintfiles
Checking whether git is clean ... yes.
Indexing SlackBuilds ... done.
git repo: /var/lib/repo/SBo/slackbuilds
branch:   HEAD
date:     Sun Jun 23 01:55:34 GMT 2024
revision: 0d5a714e2d7b026bf1162ea407bd4f25fc9a27f1
title:    Merge 5c166688c0669540fa97c9acb8ae97495ef57803 into 48891f3f0a8035561a86a0447ffab9edaab66f9f

================================================================================
system/realtek-bt                                                       01:56:28
================================================================================

Calculating dependencies ... 
Hints for system/realtek-bt:
  PRAGMA="download_urldecode download_basename kernelmodule unset_ARCH"
Dependency tree:
system/realtek-bt (update for git 5c16668)
  system/p7zip (ok)

Building system/realtek-bt (update for git 5c16668) ------------------- 01:56:28
Testing SlackBuild files ... done.
Downloading source files ...
#=#=#                                                                          
##O#-#                                                                         

######################################################################## 100.0%##O=#  #                                                                       
#-#O=#  #                                                                      
 #=#=-#   #                                                                    

######################################################################## 100.0%
                                                                           0.5%
#                                                                          1.8%
#                                                                          2.1%
####                                                                       6.4%
#######                                                                   10.7%
##############                                                            19.9%
###########################                                               38.0%
######################################################                    75.6%
######################################################################## 100.0%
Verifying source files ... done.
Pragma: download_basename
Pragma: unset_ARCH
Installing dependencies ...
p7zip-17.04-i586-1_SBo: File Compression/Decompression Utility ......... [  12M]
depmod: ERROR: could not open directory /lib/modules/5.15.145: No such file or directory
depmod: FATAL: could not search modules: No such file or directory
Running realtek-bt.SlackBuild ...                                   ETA 01:57:??
env MAKEFLAGS='-j24 -l13' nice -n 5 bash ./realtek-bt.SlackBuild
Built ok:  realtek-bt-20201202_5.15.161_smp-i586-4_SBo.txz              01:56:34
Testing package realtek-bt-20201202_5.15.161_smp-i586-4_SBo.txz ... done.
Test installing realtek-bt-20201202_5.15.161_smp-i586-4_SBo.txz ...
realtek-bt-20201202_5.15.161_smp-i586-4_SBo: Driver for realtek based us [  80K]
Driver installed, please reboot your system.
WARNING: system/realtek-bt: Possible error message from doinst.sh or installpkg
depmod: ERROR: could not open directory /lib/modules/5.15.145: No such file or directory
depmod: FATAL: could not search modules: No such file or directory
depmod: ERROR: could not open directory /lib/modules/5.15.145: No such file or directory
depmod: FATAL: could not search modules: No such file or directory
Unmounting chroot ... done.
Backed up: realtek-bt-20201202_5.15.161_smp-i586-3_SBo.txz
✅ system/realtek-bt Updated for git 5c16668 ✅

================================================================================
SUMMARY                                                                 01:56:35
================================================================================

Logfile:     /var/log/repo/SBo/repo_2024-06-23_01:56:27.log
Runtime:     0h 0m 8s
Updated:     1
  system/realtek-bt/realtek-bt-20201202_5.15.161_smp-i586-4_SBo.txz
Warnings:    1
  system/realtek-bt: Possible error message from doinst.sh or installpkg

@sbo-bot sbo-bot
Copy link

sbo-bot bot commented Jun 23, 2024

sbopkglint i586 system/realtek-bt

Installing dependency: p7zip
p7zip-17.04-i586-1_SBo: File Compression/Decompression Utility ......... [  12M]

Using tests from /usr/share/sbo-maintainer-tools/sbopkglint.d
Exploding /var/lib/repo/SBo/packages/15.0/i586/system/realtek-bt/realtek-bt-20201202_5.15.161_smp-i586-4_SBo.txz to /tmp/SBo/sbopkglint.xOIre6 ...OK
Running pre-doinst test...OK
Installing /var/lib/repo/SBo/packages/15.0/i586/system/realtek-bt/realtek-bt-20201202_5.15.161_smp-i586-4_SBo.txz to /tmp/SBo/sbopkglint.xOIre6 ...OK
Running test: 05-basic-sanity...OK
Running test: 10-docs...OK
Running test: 15-noarch...OK
Running test: 20-arch...OK
Running test: 25-lafiles...OK
Running test: 30-manpages...OK
Running test: 35-desktop...OK
Running test: 40-newconfig...OK
Running test: 45-doinst...OK
Running test: 50-icons...OK
Running test: 60-usr_info...OK
Running test: 65-python...OK
Running test: 70-tmp_path...OK
Running test: 75-static_libs...OK
Running test: 85-perl...OK
✅ === realtek-bt-20201202_5.15.161_smp-i586-4_SBo.txz: All tests passed ✅

@sbo-bot sbo-bot
Copy link

sbo-bot bot commented Jun 23, 2024

buildpkg x86_64 system/realtek-bt

Creating hintfile directory: /etc/repo/SBo/hintfiles
Checking whether git is clean ... yes.
Indexing SlackBuilds ... done.
git repo: /var/lib/repo/SBo/slackbuilds
branch:   HEAD
date:     Sun Jun 23 01:55:34 GMT 2024
revision: 0d5a714e2d7b026bf1162ea407bd4f25fc9a27f1
title:    Merge 5c166688c0669540fa97c9acb8ae97495ef57803 into 48891f3f0a8035561a86a0447ffab9edaab66f9f

================================================================================
system/realtek-bt                                                       01:57:16
================================================================================

Calculating dependencies ... 
Hints for system/realtek-bt:
  PRAGMA="download_urldecode download_basename kernelmodule unset_ARCH"
Dependency tree:
system/realtek-bt (update for git 5c16668)
  system/p7zip (ok)

Building system/realtek-bt (update for git 5c16668) ------------------- 01:57:16
Testing SlackBuild files ... done.
Downloading source files ...
#=#=#                                                                          
##O#-#                                                                         
##O=#  #                                                                       

######################################################################## 100.0%#=#=-#  #                                                                      
 #=#=-#   #                                                                    
 -#O#-  #   #                                                                  

######################################################################## 100.0%
                                                                           0.5%
#                                                                          1.8%
##                                                                         3.5%
###                                                                        5.5%
######                                                                     9.4%
############                                                              17.6%
#######################                                                   32.7%
##############################################                            65.1%
######################################################################## 100.0%
Verifying source files ... done.
Pragma: download_basename
Pragma: unset_ARCH
Installing dependencies ...
p7zip-17.04-x86_64-1_SBo: File Compression/Decompression Utility ....... [  12M]
depmod: ERROR: could not open directory /lib/modules/5.15.145: No such file or directory
depmod: FATAL: could not search modules: No such file or directory
Running realtek-bt.SlackBuild ...                                   ETA 01:57:??
env MAKEFLAGS='-j24 -l13' nice -n 5 bash ./realtek-bt.SlackBuild
Built ok:  realtek-bt-20201202_5.15.161-x86_64-9_SBo.txz                01:57:21
Testing package realtek-bt-20201202_5.15.161-x86_64-9_SBo.txz ... done.
Test installing realtek-bt-20201202_5.15.161-x86_64-9_SBo.txz ...
realtek-bt-20201202_5.15.161-x86_64-9_SBo: Driver for realtek based usb  [ 150K]
Driver installed, please reboot your system.
WARNING: system/realtek-bt: Possible error message from doinst.sh or installpkg
depmod: ERROR: could not open directory /lib/modules/5.15.145: No such file or directory
depmod: FATAL: could not search modules: No such file or directory
depmod: ERROR: could not open directory /lib/modules/5.15.145: No such file or directory
depmod: FATAL: could not search modules: No such file or directory
Unmounting chroot ... done.
Backed up: realtek-bt-20201202_5.15.161-x86_64-8_SBo.txz
✅ system/realtek-bt Updated for git 5c16668 ✅

================================================================================
SUMMARY                                                                 01:57:23
================================================================================

Logfile:     /var/log/repo/SBo/repo_2024-06-23_01:57:15.log
Runtime:     0h 0m 8s
Updated:     1
  system/realtek-bt/realtek-bt-20201202_5.15.161-x86_64-9_SBo.txz
Warnings:    1
  system/realtek-bt: Possible error message from doinst.sh or installpkg

@sbo-bot sbo-bot
Copy link

sbo-bot bot commented Jun 23, 2024

sbopkglint x86_64 system/realtek-bt

Installing dependency: p7zip
p7zip-17.04-x86_64-1_SBo: File Compression/Decompression Utility ....... [  12M]

Using tests from /usr/share/sbo-maintainer-tools/sbopkglint.d
Exploding /var/lib/repo/SBo/packages/15.0/x86_64/system/realtek-bt/realtek-bt-20201202_5.15.161-x86_64-9_SBo.txz to /tmp/SBo/sbopkglint.GB2gTn ...OK
Running pre-doinst test...OK
Installing /var/lib/repo/SBo/packages/15.0/x86_64/system/realtek-bt/realtek-bt-20201202_5.15.161-x86_64-9_SBo.txz to /tmp/SBo/sbopkglint.GB2gTn ...OK
Running test: 05-basic-sanity...OK
Running test: 10-docs...OK
Running test: 15-noarch...OK
Running test: 20-arch...OK
Running test: 25-lafiles...OK
Running test: 30-manpages...OK
Running test: 35-desktop...OK
Running test: 40-newconfig...OK
Running test: 45-doinst...OK
Running test: 50-icons...OK
Running test: 60-usr_info...OK
Running test: 65-python...OK
Running test: 70-tmp_path...OK
Running test: 75-static_libs...OK
Running test: 85-perl...OK
✅ === realtek-bt-20201202_5.15.161-x86_64-9_SBo.txz: All tests passed ✅

@willysr
Copy link
Member

willysr commented Jun 23, 2024

LGTM

@willysr
Copy link
Member

willysr commented Jun 23, 2024

merged

@willysr willysr closed this Jun 23, 2024
@willysr willysr deleted the realtek-bt branch June 23, 2024 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aclemons @willysr