Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test case for POST /v1/embeddings #63

Merged
merged 1 commit into from
Aug 23, 2024

Conversation

Murkeee
Copy link
Contributor

@Murkeee Murkeee commented Aug 22, 2024

Description

This PR fixes #32

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

@Aisuko Aisuko requested a review from cbh778899 August 22, 2024 23:40
@Aisuko Aisuko added the enhancement New feature or request label Aug 22, 2024
Copy link
Collaborator

@cbh778899 cbh778899 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cbh778899
Copy link
Collaborator

btw, I think you've got the permission to clone and push, in that way you can pass the linter action. Merge from fork won't access the repo's key so it will fail every time.

@cbh778899 cbh778899 merged commit e3c7ec7 into SkywardAI:main Aug 23, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Add test cases for POST /v1/embeddings
3 participants