code optimizations accepted?#12
Open
TheDigitalOrchard wants to merge 2 commits intoSkylarKelty:masterfrom
Open
code optimizations accepted?#12TheDigitalOrchard wants to merge 2 commits intoSkylarKelty:masterfrom
TheDigitalOrchard wants to merge 2 commits intoSkylarKelty:masterfrom
Conversation
… add REGEX_TAG constant to avoid recreating variable each time function runs
TheDigitalOrchard
changed the title
TheDigitalOrchard
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do you accept pull requests? I know this library hasn't been updated in 11 years, but it has great potential and I'd like to see it maintained to the latest PHP standards.
Since performance is one of the motivating goals, I wanted to offer up the following optimizations:
There is no functional difference with this PR, only syntax cleanup.