Skip to content

Conversation

@Janno
Copy link
Contributor

@Janno Janno commented Nov 5, 2025

Examples (from test cases; absolute counts are not correct):


No Changes in Warnings or Errors


Changes in Warnings or Errors

Before New Fixed After
Errors 0 1 0 1
Warnings 0 1 0 1

❌ New Errors (1)

File "test.v", line 44, characters 19-20:
Error: Syntax error: '.' expected after [command] (in [vernac_aux]).

⚠️ New Warnings (1)

File "test.v", line 0, characters 0-0:
Warning: Non-empty stdout when building using coqc:
dangling text!
[non-empty-stdout,dummy]

Changes in Warnings or Errors

Before New Fixed After
Errors 1 0 1 0
Warnings 1 0 1 0

❎ Fixed Errors (1)

File "test.v", line 44, characters 19-20:
Error: Syntax error: '.' expected after [command] (in [vernac_aux]).

💚 Fixed Warnings (1)

File "test.v", line 0, characters 0-0:
Warning: Non-empty stdout when building using coqc:
dangling text!
[non-empty-stdout,dummy]

@Janno Janno changed the title Code quality CI: Code quality Nov 5, 2025
@github-actions
Copy link

github-actions bot commented Nov 5, 2025

Performance summary for https://github.com/SkylabsAI/workspace/actions/runs/19102842187

Relative Master MR Change Filename
+0.00% 116922.2 116922.2 +0.0 total
+0.00% 22019.8 22019.8 +0.0 ├ translation units
+0.00% 94902.3 94902.3 +0.0 └ proofs and tests
Full Results
Relative Master MR Change Filename
+0.00% 116922.2 116922.2 +0.0 total
+0.00% 22019.8 22019.8 +0.0 ├ translation units
+0.00% 94902.3 94902.3 +0.0 └ proofs and tests

@github-actions
Copy link

github-actions bot commented Nov 6, 2025

Performance summary for https://github.com/SkylabsAI/workspace/actions/runs/19134908446

Relative Master MR Change Filename
+0.01% 116952.4 116968.5 +16.1 total
-0.01% 22013.8 22016.4 -2.6 ├ translation units
+0.02% 94954.7 94936.0 +18.7 └ proofs and tests
Full Results
Relative Master MR Change Filename
-13.58% 57.8 49.9 -7.8 fmdeps/auto/coq-bluerock-auto-cpp/tests/micromega/micromega1.v
+0.44% 391.1 392.8 +1.7 bluerock/bhv/apps/vmm/proof/main_cpp_proof.v
+0.67% 338.4 340.7 +2.3 bluerock/bhv/apps/vswitch/lib/forwarding/proof/transaction_protocol/hints.v
+3.94% 41.1 42.7 +1.6 bluerock/bhv/apps/vswitch/proof/upstream/hints.v
+0.01% 116952.4 116968.5 +16.1 total
-0.01% 22013.8 22016.4 -2.6 ├ translation units
+0.02% 94954.7 94936.0 +18.7 └ proofs and tests

1 similar comment
@github-actions
Copy link

github-actions bot commented Nov 6, 2025

Performance summary for https://github.com/SkylabsAI/workspace/actions/runs/19134908446

Relative Master MR Change Filename
+0.01% 116952.4 116968.5 +16.1 total
-0.01% 22013.8 22016.4 -2.6 ├ translation units
+0.02% 94954.7 94936.0 +18.7 └ proofs and tests
Full Results
Relative Master MR Change Filename
-13.58% 57.8 49.9 -7.8 fmdeps/auto/coq-bluerock-auto-cpp/tests/micromega/micromega1.v
+0.44% 391.1 392.8 +1.7 bluerock/bhv/apps/vmm/proof/main_cpp_proof.v
+0.67% 338.4 340.7 +2.3 bluerock/bhv/apps/vswitch/lib/forwarding/proof/transaction_protocol/hints.v
+3.94% 41.1 42.7 +1.6 bluerock/bhv/apps/vswitch/proof/upstream/hints.v
+0.01% 116952.4 116968.5 +16.1 total
-0.01% 22013.8 22016.4 -2.6 ├ translation units
+0.02% 94954.7 94936.0 +18.7 └ proofs and tests

@github-actions
Copy link

github-actions bot commented Nov 6, 2025

Performance summary for https://github.com/SkylabsAI/workspace/actions/runs/19137074957

Relative Master MR Change Filename
+0.01% 116952.5 116968.6 +16.1 total
-0.01% 22013.9 22016.5 -2.5 ├ translation units
+0.02% 94954.7 94936.0 +18.7 └ proofs and tests
Full Results
Relative Master MR Change Filename
-13.58% 57.8 49.9 -7.8 fmdeps/auto/coq-bluerock-auto-cpp/tests/micromega/micromega1.v
+0.44% 391.1 392.8 +1.7 bluerock/bhv/apps/vmm/proof/main_cpp_proof.v
+0.67% 338.4 340.7 +2.3 bluerock/bhv/apps/vswitch/lib/forwarding/proof/transaction_protocol/hints.v
+3.94% 41.1 42.7 +1.6 bluerock/bhv/apps/vswitch/proof/upstream/hints.v
+0.01% 116952.5 116968.6 +16.1 total
-0.01% 22013.9 22016.5 -2.5 ├ translation units
+0.02% 94954.7 94936.0 +18.7 └ proofs and tests

@Janno Janno force-pushed the janno/CI branch 2 times, most recently from 09cb862 to 1e550cb Compare November 7, 2025 11:04
@github-actions
Copy link

github-actions bot commented Nov 7, 2025

Performance summary for https://github.com/SkylabsAI/workspace/actions/runs/19166432732

Relative Master MR Change Filename
+0.01% 116952.4 116968.5 +16.1 total
-0.01% 22013.8 22016.4 -2.6 ├ translation units
+0.02% 94954.7 94936.0 +18.7 └ proofs and tests
Full Results
Relative Master MR Change Filename
-13.58% 57.8 49.9 -7.8 fmdeps/auto/coq-bluerock-auto-cpp/tests/micromega/micromega1.v
+0.44% 391.1 392.8 +1.7 bluerock/bhv/apps/vmm/proof/main_cpp_proof.v
+0.67% 338.4 340.7 +2.3 bluerock/bhv/apps/vswitch/lib/forwarding/proof/transaction_protocol/hints.v
+3.94% 41.1 42.7 +1.6 bluerock/bhv/apps/vswitch/proof/upstream/hints.v
+0.01% 116952.4 116968.5 +16.1 total
-0.01% 22013.8 22016.4 -2.6 ├ translation units
+0.02% 94954.7 94936.0 +18.7 └ proofs and tests

@github-actions
Copy link

github-actions bot commented Nov 7, 2025

Performance summary for https://github.com/SkylabsAI/workspace/actions/runs/19166874313

Relative Master MR Change Filename
+0.01% 116952.4 116968.6 +16.2 total
-0.01% 22014.0 22016.4 -2.4 ├ translation units
+0.02% 94954.7 94936.0 +18.7 └ proofs and tests
Full Results
Relative Master MR Change Filename
-13.58% 57.8 49.9 -7.8 fmdeps/auto/coq-bluerock-auto-cpp/tests/micromega/micromega1.v
+0.44% 391.1 392.8 +1.7 bluerock/bhv/apps/vmm/proof/main_cpp_proof.v
+0.67% 338.4 340.7 +2.3 bluerock/bhv/apps/vswitch/lib/forwarding/proof/transaction_protocol/hints.v
+3.94% 41.1 42.7 +1.6 bluerock/bhv/apps/vswitch/proof/upstream/hints.v
+0.01% 116952.4 116968.6 +16.2 total
-0.01% 22014.0 22016.4 -2.4 ├ translation units
+0.02% 94954.7 94936.0 +18.7 └ proofs and tests

@github-actions
Copy link

github-actions bot commented Nov 7, 2025

Performance summary for https://github.com/SkylabsAI/workspace/actions/runs/19167318227

Relative Master MR Change Filename
+0.01% 116952.4 116968.5 +16.1 total
-0.01% 22013.8 22016.4 -2.6 ├ translation units
+0.02% 94954.7 94936.0 +18.7 └ proofs and tests
Full Results
Relative Master MR Change Filename
-13.58% 57.8 49.9 -7.8 fmdeps/auto/coq-bluerock-auto-cpp/tests/micromega/micromega1.v
+0.44% 391.1 392.8 +1.7 bluerock/bhv/apps/vmm/proof/main_cpp_proof.v
+0.67% 338.4 340.7 +2.3 bluerock/bhv/apps/vswitch/lib/forwarding/proof/transaction_protocol/hints.v
+3.94% 41.1 42.7 +1.6 bluerock/bhv/apps/vswitch/proof/upstream/hints.v
+0.01% 116952.4 116968.5 +16.1 total
-0.01% 22013.8 22016.4 -2.6 ├ translation units
+0.02% 94954.7 94936.0 +18.7 └ proofs and tests

@github-actions
Copy link

github-actions bot commented Nov 7, 2025

Performance summary for https://github.com/SkylabsAI/workspace/actions/runs/19167890543

Relative Master MR Change Filename
+0.01% 116952.5 116968.6 +16.1 total
-0.01% 22014.0 22016.5 -2.5 ├ translation units
+0.02% 94954.7 94936.0 +18.7 └ proofs and tests
Full Results
Relative Master MR Change Filename
-13.58% 57.8 49.9 -7.8 fmdeps/auto/coq-bluerock-auto-cpp/tests/micromega/micromega1.v
+0.44% 391.1 392.8 +1.7 bluerock/bhv/apps/vmm/proof/main_cpp_proof.v
+0.67% 338.4 340.7 +2.3 bluerock/bhv/apps/vswitch/lib/forwarding/proof/transaction_protocol/hints.v
+3.94% 41.1 42.7 +1.6 bluerock/bhv/apps/vswitch/proof/upstream/hints.v
+0.01% 116952.5 116968.6 +16.1 total
-0.01% 22014.0 22016.5 -2.5 ├ translation units
+0.02% 94954.7 94936.0 +18.7 └ proofs and tests

@Janno Janno marked this pull request as ready for review November 7, 2025 12:24
Copy link
Contributor

@rlepigre-skylabs-ai rlepigre-skylabs-ai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks reasonable, but as we discussed earlier, it might be useful to rely on the dune-report tool to collect errors.

@github-actions
Copy link

Performance summary for https://github.com/SkylabsAI/workspace/actions/runs/19272519706

Relative Master MR Change Filename
-0.00% 116925.8 116925.3 -0.5 total
-0.01% 22013.8 22016.4 -2.6 ├ translation units
+0.00% 94911.5 94909.4 +2.1 └ proofs and tests
Full Results
Relative Master MR Change Filename
-13.58% 57.8 49.9 -7.8 fmdeps/auto/coq-bluerock-auto-cpp/tests/micromega/micromega1.v
-4.67% 115.5 110.1 -5.4 bluerock/bhv/apps/umx/proof/main_cpp_proof/output_loop.v
-0.00% 116925.8 116925.3 -0.5 total
-0.01% 22013.8 22016.4 -2.6 ├ translation units
+0.00% 94911.5 94909.4 +2.1 └ proofs and tests

@github-actions
Copy link

Performance summary for https://github.com/SkylabsAI/workspace/actions/runs/19272894508

Relative Master MR Change Filename
-0.00% 116925.8 116925.3 -0.5 total
-0.01% 22013.9 22016.5 -2.6 ├ translation units
+0.00% 94911.5 94909.4 +2.1 └ proofs and tests
Full Results
Relative Master MR Change Filename
-13.58% 57.8 49.9 -7.8 fmdeps/auto/coq-bluerock-auto-cpp/tests/micromega/micromega1.v
-4.67% 115.5 110.1 -5.4 bluerock/bhv/apps/umx/proof/main_cpp_proof/output_loop.v
-0.00% 116925.8 116925.3 -0.5 total
-0.01% 22013.9 22016.5 -2.6 ├ translation units
+0.00% 94911.5 94909.4 +2.1 └ proofs and tests

@github-actions
Copy link

Performance summary for https://github.com/SkylabsAI/workspace/actions/runs/19295970355

Relative Master MR Change Filename
-0.00% 116925.8 116925.3 -0.5 total
-0.01% 22013.8 22016.4 -2.6 ├ translation units
+0.00% 94911.5 94909.4 +2.1 └ proofs and tests
Full Results
Relative Master MR Change Filename
-13.58% 57.8 49.9 -7.8 fmdeps/auto/coq-bluerock-auto-cpp/tests/micromega/micromega1.v
-4.67% 115.5 110.1 -5.4 bluerock/bhv/apps/umx/proof/main_cpp_proof/output_loop.v
-0.00% 116925.8 116925.3 -0.5 total
-0.01% 22013.8 22016.4 -2.6 ├ translation units
+0.00% 94911.5 94909.4 +2.1 └ proofs and tests

1 similar comment
@github-actions
Copy link

Performance summary for https://github.com/SkylabsAI/workspace/actions/runs/19295970355

Relative Master MR Change Filename
-0.00% 116925.8 116925.3 -0.5 total
-0.01% 22013.8 22016.4 -2.6 ├ translation units
+0.00% 94911.5 94909.4 +2.1 └ proofs and tests
Full Results
Relative Master MR Change Filename
-13.58% 57.8 49.9 -7.8 fmdeps/auto/coq-bluerock-auto-cpp/tests/micromega/micromega1.v
-4.67% 115.5 110.1 -5.4 bluerock/bhv/apps/umx/proof/main_cpp_proof/output_loop.v
-0.00% 116925.8 116925.3 -0.5 total
-0.01% 22013.8 22016.4 -2.6 ├ translation units
+0.00% 94911.5 94909.4 +2.1 └ proofs and tests

@Janno Janno merged commit e9796d0 into main Nov 12, 2025
27 checks passed
@pgiarrusso-sl pgiarrusso-sl deleted the janno/CI branch November 12, 2025 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants