Make build-list.py a stand-alone script #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows us to typecheck it independently using ``` uvx --with-requirements build-list.py ty check build-list.py ```
|
Performance summary for https://github.com/SkylabsAI/workspace/actions/runs/19098214687
Full Results
|
rlepigre-skylabs-ai
approved these changes
Nov 5, 2025
Contributor
rlepigre-skylabs-ai
left a comment
rlepigre-skylabs-ai
left a comment
There was a problem hiding this comment.
This looks good to me, and means we can avoid calling uv run -- in the dune file I think.
Contributor
|
This seems like a good change. Can we fix the type error and get it merged? |
Contributor
Author
Can you fix it? I haven't actually read the code. |
|
Performance summary for https://github.com/SkylabsAI/workspace/actions/runs/19180075054
Full Results
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am not sure we actually want this. Perhaps it should instead become part of a bigger python project that contains most/all of our infrastructure python code.
TODO:
uvx tyuvx tyon this without a virtual env (my local tests were not performed thoroughly enough)