-
Notifications
You must be signed in to change notification settings - Fork 0
Add basic .devcontainer setup #35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Performance summary for https://github.com/SkylabsAI/workspace/actions/runs/19040274869
Full Results
|
|
For reference, here is what we used to have before: {
"name": "FM Default",
"image": "ghcr.io/skylabsai/skylabs-fm:fm-default",
"customizations": {
"vscode": {
"settings": {
"vscoq.path": "/workspaces/skylabs-fm/_build/install/default/bin/vscoqtop"
},
"extensions": [
"maximedenes.vscoq",
"ocamllabs.ocaml-platform"
]
}
},
"mounts": [
"source=${localEnv:HOME}/.cache/dune,target=/home/coq/.cache/dune,type=bind,consistency=cached"
]
} |
rlepigre-skylabs-ai
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would make sense to at least change the name.
Maybe we should also bring in the cache mounting we had in the config I posted above, and the OCaml extension?
We were also using a different vsrocq extension it seems?
|
What I sent is simplified from https://github.com/SkylabsAI/fm-ci/blob/main/devcontainer/devcontainer.json, documented in
|
|
ah, https://containers.dev/implementors/json_reference/#variables-in-devcontainerjson supports defaults! Then we can maybe have our cake and eat it too — at least if nested references work:
EDIT: I can check devcontainers/spec#255. |
c173cd2 to
32fd953
Compare
|
I only care that the cache used in the devcontainer is shared among different instances of the devcontainer. I guess we could eventually allow people to locally mount the NFS cache? Though this might not be an improvement depending on the network. |
32fd953 to
cc4efb6
Compare
|
Performance summary for https://github.com/SkylabsAI/workspace/actions/runs/19303425469
Full Results
|
cc4efb6 to
c5788c8
Compare
|
Performance summary for https://github.com/SkylabsAI/workspace/actions/runs/19305940636
Full Results
|
|
We discussed and tested this together, so merging. |
No description provided.