Disable firmware auto-inclusion and add initrd safety check - #1
Open
Reonarudo wants to merge 1 commit into
Open
Conversation
firmware-qcom-soc in Debian sid (20260110-1) depends on firmware-qcom-dsp which doesn't exist yet, causing lb build to fail with 1000+ unresolved dependencies. Since sky1-firmware already provides the hardware-specific firmware needed for CIX Sky1 SoC, disable live-build's automatic firmware inclusion to avoid breakage from transient Debian sid dependency issues. Also add a check in build-image.sh to abort with a clear error if initrd.img is missing, preventing silently broken images.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--firmware-binaryand--firmware-chrootinauto/config—firmware-qcom-socin Debian sid (20260110-1) depends onfirmware-qcom-dsp, causinglb buildto fail with 1000+ unresolved dependencies (includinginitramfs-tools). Sincesky1-firmwarealready provides the hardware-specific firmware for CIX Sky1 SoC, there's no need for live-build to auto-install every firmware package from Debian'snon-free-firmwaresection.build-image.sh— if the chroot is broken (e.g. from a failedlb build),build-image.shwould previously produce a disk image with a GRUB config referencing a non-existentinitrd.img, resulting in an unbootable image. Now it aborts with a clear error.Context
When building with
./scripts/build.sh xfce developer image clean, the build fails duringlb buildbecause the Debian sid package resolver cannot satisfyfirmware-qcom-soc → firmware-qcom-dsp. The chroot ends up partially built (kernel installed but noinitramfs-tools), andbuild-image.shstill runs because the chroot directory exists, producing a broken ~121MB image that fails at GRUB with:Test plan
./scripts/build.sh xfce developer image cleansucceedsinitrd.img-*in/boot/build-image.shaborts with clear error