Skip to content

fix dark mode layout and LoginPopup styles and structure for improved… - #212

Open
rjeetgupta wants to merge 2 commits into
Skrishna0703:mainfrom
rjeetgupta:fix/login-register-form-dark-mode
Open

fix dark mode layout and LoginPopup styles and structure for improved…#212
rjeetgupta wants to merge 2 commits into
Skrishna0703:mainfrom
rjeetgupta:fix/login-register-form-dark-mode

Conversation

@rjeetgupta

Copy link
Copy Markdown
Contributor

Which issue does this PR close?

Closes #179

Rationale for this change

The login/signup form had several UI/UX issues affecting readability and consistency in dark mode. Additionally, duplicate login/register buttons and inconsistent spacing were impacting the overall user experience. This PR resolves these problems to improve responsiveness, maintain design consistency, and provide a cleaner interface.

What changes are included in this PR?

  • Fixed dark mode support for the login/signup form
  • Removed unnecessary duplicate login/register button rendering
  • Adjusted spacing for better layout and readability

Are these changes tested?

[x] Verified in dark mode and light mode
[x] Checked responsiveness across different screen sizes
[x] Confirmed buttons and form functionality work as expected

Are there any user-facing changes?

Yes.

  • Users will now see proper dark mode styling on the login/signup form.
  • Only one login/register button is displayed.
  • Layout spacing has been fixed, improving overall readability.

Screenshots (if applicable)
image
image

@github-actions

Copy link
Copy Markdown

Thanks for creating a PR for your Issue! ☺️

We'll review it as soon as possible.
In the meantime, please double-check the file changes and ensure that all commits are accurate.

If there are any unresolved review comments, feel free to resolve them. 🙌🏼

@Skrishna0703 Skrishna0703 added GSSOC 25 Issues/PRs participating in GirlScript Summer of Code 2025 Level 1 Easy issue - 3 Points (GSSoC'25) labels Sep 26, 2025
@Skrishna0703

Copy link
Copy Markdown
Owner
image

@rjeetgupta

Copy link
Copy Markdown
Contributor Author

Hi @Skrishna0703,
In the last pull request you merged, there were some changes to the login made by another user, and I got a conflict error. I will resolve it, but the merged PR also changed the style of the login and register pages. Should I keep the style changes I already made, or just resolve the merge conflict and push again? I am attaching a screenshot so you can see the changes made by the other user.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

GSSOC 25 Issues/PRs participating in GirlScript Summer of Code 2025 Level 1 Easy issue - 3 Points (GSSoC'25)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update Login/Signup form to match dark mode UI

2 participants