Backport #2859 to release/2.1.x #2890
Conversation
|
Please squash this mess if it will ever build 😅 I've seen some unrelated WEBP test failures locally, probably they will show up here. |
|
Even BMP failures. I don't understand this, neither we changed the product code nor we added tests since 2.1.9. Will continue investigating tomorrow, but if anyone has an idea, let me know! |
|
@antonfirsov Github keeps changing what’s installed on images. I discovered with V3 branch that weirdly you had to install NET 8 along with the current target version for anything to build. I would use the yaml file from that branch as the basis and change the target frameworks. |
|
I cannot reproduce the bmp test failures on windows. When I run: All tests are green. |
| if (TestEnvironment.IsLinux) | ||
| { | ||
| throw new SkipTestException("See discussion on https://github.com/SixLabors/ImageSharp/pull/2890"); | ||
| } |
There was a problem hiding this comment.
The Linux failure is a mystery: it only shows when running the test suite. If I run a console app against the compiled ImageSharp.dll on Ubuntu, the image loads without an issue. I have spent an hour trying to hook a debugger into VS Code, but it keeps ignoring my breakpoints.
I ended up skipping the test on Linux. (1) It's likely a false alert that appears only with dotnet test (2) likely not a regression against the previous version, (3) an edge-case anyways.
There was a problem hiding this comment.
I think it is ok to skip those bmp tests on linux, they are extremely niche bitmap variants. It's also a mystery to me why this is different on linux than on windows.
There was a problem hiding this comment.
It was an LFS issue (╯°□°)╯︵ ┻━┻
I had to add capital-case *.BMP to the relevant gitattributes list to make Linux happy. No idea why don't we have it on other branches.
| - name: Install Ubuntu prerequisites | ||
| if: ${{ contains(matrix.options.os, 'ubuntu') }} | ||
| run: | | ||
| # libssl 1.1 (required by old .NET runtimes) | ||
| wget http://archive.ubuntu.com/ubuntu/pool/main/o/openssl/libssl1.1_1.1.0g-2ubuntu4_amd64.deb | ||
| sudo dpkg -i libssl1.1_1.1.0g-2ubuntu4_amd64.deb | ||
|
|
||
| # libgdiplus | ||
| sudo apt-get -y install libgdiplus libgif-dev libglib2.0-dev libcairo2-dev libtiff-dev libexif-dev | ||
|
|
There was a problem hiding this comment.
I would use the yaml file from that branch as the basis and change the target frameworks.
I decided to keep the current state as the basis to avoid accidentally changing the package targets.
The magic to revive old .NET versions is to manually install libssl 1.1.
|
@JimBobSquarePants it should be good to merge this now and start publishing stuff. |
Prerequisites
Description
Backport #2859 to release/2.1.x