Follow-up: enforce positive whole page values in Collection pagination

[chadwickmeyer]

Motivation

• Prevent invalid page values from user-controlled query parameters (e.g. -1, 1.5, Infinity, NaN) being forwarded to the API via api.p and causing incorrect pagination.
• Centralize page-number validation so all pagination entry points behave consistently and defensively.

Description

• Added a private helper normalizePositiveWholeNumber() that returns a finite integer >= 1 or undefined for invalid inputs.
• In sync() added defensive handling for data.p so p is normalized and removed when invalid before serializing the request.
• Updated page(page) to validate the incoming page value, short-circuit on invalid input, and only set meta.api.p when the value is a valid whole positive number.

Testing

• Ran git diff --check to validate there are no whitespace/patch issues and it passed.
• Inspected the changes with git diff to verify the intended edits to packages/angularjs/src/services/collection.ts were applied as expected.

---

Codex Task

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 743bf17bf4

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[chatgpt-codex-connector]

Guard api metadata before deleting page on invalid input

In page(), the invalid-input branch calls delete this.meta.get('api').p before any code ensures meta.api exists. For a fresh Collection where no api metadata has been set yet, this.meta.get('api') is undefined, so this throws at runtime instead of safely ignoring the bad page value; this means malformed page params can now crash pagination flow rather than being handled defensively.

Useful? React with 👍 / 👎.