Skip to content

FIX Meet the estate contract (#7) - #8

Merged
allrude merged 1 commit into
mainfrom
fix/7-estate-contract
Oct 6, 2026
Merged

allrude merged 1 commit into
mainfrom
fix/7-estate-contract

Conversation

@allrude

@allrude allrude commented Oct 6, 2026

Copy link
Copy Markdown
Member

Closes #7.

Adds a PHPUnit 12 suite (ViewModel unit tests) with CI, and narrows magento/framework to ~103.0.9, which drops Magento 102 support (owner decision 2026-10-06).

The vendor name rule is exempt for siteation/* via Siteation/nebula-dev-tools#66. Gate on fresh clones: module-tests and the framework range red on main, green on this branch.

Adds a PHPUnit 12 suite with the ViewModel unit tests, CI that runs it,
and narrows magento/framework to ~103.0.9 per the estate gate. Drops
Magento 102 support.
@allrude

allrude commented Oct 6, 2026

Copy link
Copy Markdown
Member Author

Review at 07b110f PASS

Estate contract met: magento/framework is ~103.0.9 (the only framework constraint the manifests gate in dev-tools enforces), phpunit ^12 in require-dev, vendor name siteation/ kept (exempt since dev-tools#66, merged). module-backend ^102.0 is the real backend line on 2.4.9, not the old framework 102.
CI at this head: unit 8.3 and 8.4 pass, run headSha equals PR head, MERGEABLE. PHPUnit ran: 9 tests, 20 assertions.
Not checked: Composer resolution of the full dependency set outside CI (CI does composer update on the Mage-OS mirror, which passed).

@allrude
allrude merged commit a5d4c23 into main Oct 6, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Estate gates fail: no unit test, framework range, vendor name

1 participant