Dp less 4 #13
Open
Dp less 4 #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ние в админке как с помощью formset, так и с помощью lQuery на странице со списком заказов
![code-review-doctor[bot]](https://avatars.githubusercontent.com/in/83430?s=60&v=4){kind=small}
| ) | ||
|
|
||
| # удалять заказы пользователя если пользователь был удалён - не самая лучшая идея, по этому выставлю SET_NULL | ||
| user = models.ForeignKey(settings.AUTH_USER_MODEL, on_delete=models.SET_NULL, null=True) |
There was a problem hiding this comment.
Suggested change
| user = models.ForeignKey(settings.AUTH_USER_MODEL, on_delete=models.SET_NULL, null=True) | |
| user = models.ForeignKey( | |
| settings.AUTH_USER_MODEL, on_delete=models.SET_NULL, null=True, blank=True | |
| ) |
Django automatically creates a related_name if it's not set. If it were set then a more readable and explicit relationship is set up.
Expect unwanted behavior if null and blank are different values: null controls if the database allows no value for user and blank controls if the application allows no value for user. Consider setting null and blank to the same value for user.
|
|
||
| class OrderItem(models.Model): | ||
| order = models.ForeignKey(Order, related_name="order_items", on_delete=models.CASCADE) | ||
| product = models.ForeignKey(Product, verbose_name='продукт', on_delete=models.CASCADE) |
There was a problem hiding this comment.
Again, with an explicit related_name would be better.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Извиняюсь, на работе завал, на выходных сделаю и пришлю