fix(hooks): restrict prompt entity injection types#797
Conversation
|
Review posted through GitHub's PR review UI for commit |
PR-Reviewer-Ant
left a comment
There was a problem hiding this comment.
Review metadata
- Reviewer: pr-reviewer
- Model:
gpt-5.5 - Commit:
15867931
I did not find a concrete blocker in this diff. The implementation matches the PR description: prompt-submit entity selection is narrowed to person/project entities, generic one-token entities are filtered, possessive matching is preserved, and the Rust shadow path has matching regressions.
Confidence: Medium [sufficient_diff_evidence, missing_runtime_repro] - The selector behavior is directly visible in platform/daemon/src/hooks.ts and mirrored in platform/daemon-rs/crates/signet-daemon/src/routes/hooks.rs, with targeted TS and Rust tests covering possessives, disallowed entity types, generic plural terms, and longest non-overlapping spans. I did not run the stated validation commands or inspect the live ontology data distribution, so residual risk is mainly around real-world scoring thresholds rather than a provable diff bug.
Summary
personandprojectentitiesValidation
bunx biome check platform/daemon/src/hooks.ts platform/daemon/src/hooks.prompt-submit.test.tsbun test platform/daemon/src/hooks.prompt-submit.test.tscargo test -p signet-daemon prompt_submitbun run build:signetaisignet daemon restart --no-syncsignet prompt contextandsignets prompt contextinject;projects roadmap,agents are useful,tools setup,claude code connector setup, andcontextstay silentNotes
nicholais favorite penscurrently resolves the person entity but returnsno-aspect-hitbecause the clean pen fact is not represented as a current Nicholai ontology attribute.PR Readiness (MANDATORY)
INDEX.md+dependencies.yaml)Migration Notes (if applicable)