Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Snyk] Security upgrade axios from 1.7.7 to 1.8.2 #7242

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

ankitnayan
Copy link
Collaborator

@ankitnayan ankitnayan commented Mar 8, 2025

snyk-top-banner

Snyk has created this PR to fix 1 vulnerabilities in the yarn dependencies of this project.

Snyk changed the following file(s):

  • frontend/package.json
  • frontend/yarn.lock

Note for zero-installs users

If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the .yarn/cache/ directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to run yarn to update the contents of the ./yarn/cache directory.
If you are not using zero-install you can ignore this as your flow should likely be unchanged.

Vulnerabilities that will be fixed with an upgrade:

Issue Score
medium severity Server-side Request Forgery (SSRF)
SNYK-JS-AXIOS-9292519
  703  

Important

  • Check the changes in this PR to ensure they won't cause issues with your project.
  • Max score is 1000. Note that the real score may have changed since the PR was raised.
  • This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic


Learn how to fix vulnerabilities with free interactive lessons:

🦉 Server-side Request Forgery (SSRF)


Important

Upgrade axios to 1.8.2 to fix SSRF vulnerability in frontend/package.json and frontend/yarn.lock.

  • Security Update:
    • Upgrade axios from 1.7.7 to 1.8.2 in frontend/package.json and frontend/yarn.lock to fix SSRF vulnerability (SNYK-JS-AXIOS-9292519).
  • Note for Zero-Installs:
    • Does not update .yarn/cache/, requiring yarn command for zero-install projects.

This description was created by Ellipsis for 9208444. It will automatically update as commits are pushed.

@ankitnayan ankitnayan requested a review from YounixM as a code owner March 8, 2025 06:55
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link

github-actions bot commented Mar 8, 2025

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

1 similar comment
Copy link

github-actions bot commented Mar 8, 2025

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 9208444 in 46 seconds

More details
  • Looked at 13 lines of code in 1 files
  • Skipped 1 files when reviewing.
  • Skipped posting 3 drafted comments based on config settings.
1. frontend/package.json:54
  • Draft comment:
    Security upgrade: axios updated from 1.7.7 to 1.8.2 to address SSRF vulnerability (SNYK-JS-AXIOS-9292519). Ensure tests pass post-update.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50%
    This comment is related to a dependency change, specifically a security upgrade for the axios library. The comment also asks to ensure tests pass post-update, which is against the rules. Therefore, this comment should be removed.
2. frontend/package.json:54
  • Draft comment:
    The axios version update from 1.7.7 to 1.8.2 resolves the SSRF vulnerability. Please ensure that this upgrade does not break any axios usage patterns in the project by reviewing the changelog for any potential breaking changes.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50%
    This comment is related to a dependency change, specifically the axios version update. The comment asks the PR author to ensure that the upgrade does not break any usage patterns, which violates the rule against asking the author to double-check things. Additionally, it mentions reviewing the changelog for potential breaking changes, which is also a form of asking for confirmation. Therefore, this comment should be removed.
3. frontend/package.json:7
  • Draft comment:
    There's a potential typo in the script command. The key is named 'i18n:generate-hash' but it calls a file './i18-generate-hash.js'. Typically, 'i18n' stands for 'internationalization', so it might be intended to be './i18n-generate-hash.js' for consistency. Please double-check if the filename is correct.
  • Reason this comment was not posted:
    Comment was not on a location in the diff, so it can't be submitted as a review comment.

Workflow ID: wflow_bw9FC2hTExWOzJSQ


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants