fix: handle invalid invitation token gracefully in signup page

[AdityaPimpalkar]

Summary

If the sign up fails, we redirect the users to the Login Page where we should display the error message: "invalid/used/expired invitation token. Please contact your admin."

Related Issues / PR's

#7011

Screenshots

Screen.Recording.2025-02-16.at.7.17.15.p.m.mov

Affected Areas and Manually Tested Areas

frontend/src/pages/SignUp/SignUp.tsx
pkg/query-service/auth/auth.go

---

Important

Handle invalid invitation tokens by redirecting users to the login page with an error message in SignUp.tsx and updating error handling in auth.go.

• Behavior:
  • Redirects users to the login page with an error message for invalid/used/expired invitation tokens in SignUp.tsx.
  • Updates RegisterInvitedUser in auth.go to return a ForbiddenError with a specific message for invalid tokens.
• Types:
  • Adds Unavailable to ErrorType in common/index.ts.
• Misc:
  • Minor logging changes in auth.go.

^{This description was created by for fbcd6c9. It will automatically update as commits are pushed.}

[welcome]

Welcome to the SigNoz community! Thank you for your first pull request and making this project better. 🤗

[CLAassistant]

All committers have signed the CLA.

[ellipsis-dev]

❌ Changes requested. Reviewed everything up to fbcd6c9 in 2 minutes and 26 seconds

More details

• Looked at 47 lines of code in 3 files
• Skipped 0 files when reviewing.
• Skipped posting 4 drafted comments based on config settings.

1. frontend/src/pages/SignUp/SignUp.tsx:346

• Draft comment:
  Avoid using inline styles with hardcoded colors. Use design tokens or CSS classes instead of '#D89614'.
• Reason this comment was not posted:
  Comment was not on a location in the diff, so it can't be submitted as a review comment.

2. frontend/src/pages/SignUp/SignUp.tsx:357

• Draft comment:
  Avoid inline styling; extract color '#D89614' into a design token or CSS variable.
• Reason this comment was not posted:
  Comment was not on a location in the diff, so it can't be submitted as a review comment.

3. frontend/src/types/common/index.ts:30

• Draft comment:
  Added 'Unavailable' to ErrorType enum. Ensure its usage is consistent throughout the app.
• Reason this comment was not posted:
  Confidence changes required: 33% <= threshold 50%
  None

4. pkg/query-service/auth/auth.go:455

• Draft comment:
  Replacing BadRequest with ForbiddenError for invalid invitation tokens correctly signals a 403 error. This improves clarity in error handling.
• Reason this comment was not posted:
  Comment did not seem useful. Confidence is useful = 0% <= threshold 50%
  This comment is purely informative and does not provide any actionable feedback or suggestions. It simply states that a change is good, which violates the rule against making purely informative comments.

Workflow ID: wflow_XaKTa1636hdMNbop

---

Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

[AdityaPimpalkar]

Redirecting to Login page only on Forbidden errors. I'm assuming we don't want to redirect on any and all errors thrown by sign-up API, that would be a bad experience. So throwing a Forbidden instead of BadRequest made sense here.

If not then I'm open to suggestions! :)