feat: added celery task feature - with task graphs and details #6840
Conversation
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to 593d666 in 1 minute and 18 seconds
More details
- Looked at
1154lines of code in22files - Skipped
0files when reviewing. - Skipped posting
3drafted comments based on config settings.
1. frontend/src/components/CeleryTask/CeleryTaskGraph/CeleryTaskGraph.tsx:57
- Draft comment:
Remove the console.log statement to clean up the code for production.
```
- Reason this comment was not posted:
Marked as duplicate.
2. frontend/src/components/CeleryTask/CeleryTaskGraph/CeleryTaskGraph.tsx:47
- Draft comment:
Avoid using inline styles for theCardcomponent. Use external stylesheets or styled components instead. - Reason this comment was not posted:
Marked as duplicate.
3. frontend/src/components/CeleryTask/CeleryTaskConfigOptions/CeleryTaskConfigOptions.tsx:66
- Draft comment:
Avoid using inline styles for theButtoncomponent. Use external stylesheets or styled components instead. - Reason this comment was not posted:
Marked as duplicate.
Workflow ID: wflow_G1Qngh0GJjKTSYsC
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
| onClose, | ||
| }: CeleryTaskDetailProps): JSX.Element { | ||
| const isDarkMode = useIsDarkMode(); | ||
| console.log(task); |
There was a problem hiding this comment.
Remove the console.log statement to clean up the code for production.
| console.log(task); | |
| ``` |
| }} | ||
| className="celery-task-detail-drawer" | ||
| destroyOnClose | ||
| closeIcon={<X size={16} style={{ marginTop: Spacing.MARGIN_1 }} />} |
There was a problem hiding this comment.
Avoid using inline styles for the closeIcon in the Drawer component. Use external stylesheets or styled components instead.
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
1 similar comment
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on 69988a1 in 1 minute and 2 seconds
More details
- Looked at
184lines of code in4files - Skipped
0files when reviewing. - Skipped posting
3drafted comments based on config settings.
1. frontend/src/components/CeleryTask/CeleryTaskDetail/CeleryTaskDetail.tsx:28
- Draft comment:
Remove the console.log statement to clean up the code.
- Reason this comment was not posted:
Comment looked like it was already resolved.
2. frontend/src/components/CeleryTask/CeleryTaskDetail/CeleryTaskDetail.tsx:26
- Draft comment:
Avoid using inline styles. Consider using external stylesheets, CSS classes, or styled components instead. - Reason this comment was not posted:
Comment was not on a valid diff hunk.
3. frontend/src/components/CeleryTask/CeleryTaskGraph/CeleryTaskGraph.style.scss:64
- Draft comment:
Use design tokens or predefined color constants instead of hardcoding color values to maintain consistency in design and theming. This is also applicable to lines 51, 60, 75, 82, and 92. - Reason this comment was not posted:
Comment looked like it was already resolved.
Workflow ID: wflow_STQTbl1b8q63NvaN
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Summary
Related Issues / PR's
Screenshots
Screen.Recording.2025-01-17.at.8.48.48.AM.mov
Affected Areas and Manually Tested Areas
Important
Introduces a new feature for managing Celery tasks with detailed views and graphs, including routing, styling, and utility updates.
CeleryTaskcomponent inCeleryTask.tsxto display Celery task details and graphs.CeleryTaskConfigOptions,CeleryTaskDetail, andCeleryTaskGraphGridcomponents for task configuration, detail view, and graph display.CeleryTaskConfigOptions.tsx.CeleryTaskroute inroutes.tsandAppRoutes/pageComponents.ts.ROUTESinconstants/routes.tsto includeMESSAGING_QUEUES_CELERY_TASK.CeleryTask.styles.scss,CeleryTaskConfigOptions.styles.scss, andCeleryTaskGraph.style.scss.CeleryUtils.tsfor query parameter management.routePermissioninutils/permission/index.tsto includeMESSAGING_QUEUES_CELERY_TASK.This description was created by
for 69988a1. It will automatically update as commits are pushed.