Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ignore ts for panel type table #6419

Merged
merged 2 commits into from
Nov 12, 2024
Merged

fix: ignore ts for panel type table #6419

merged 2 commits into from
Nov 12, 2024

Conversation

nityanandagohain
Copy link
Member

@nityanandagohain nityanandagohain commented Nov 11, 2024

Since we don't have ts in table panel, it should not be there in expressions.


Important

Excludes ts from group tags in queries for table panel types in query_builder.go, with corresponding test updates in query_builder_test.go.

  • Behavior:
    • In query_builder.go, expressionToQuery() now excludes ts from groupTags if PanelType is v3.PanelTypeTable.
  • Tests:
    • Updated query_builder_test.go to reflect changes in expected queries for table panel types, ensuring ts is not included.

This description was created by Ellipsis for 2486059. It will automatically update as commits are pushed.

@github-actions github-actions bot added the bug Something isn't working label Nov 11, 2024
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

1 similar comment
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 2486059 in 28 seconds

More details
  • Looked at 49 lines of code in 2 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. pkg/query-service/app/queryBuilder/query_builder.go:119
  • Draft comment:
    The condition to exclude 'ts' from groupTags for table panel types is correct and aligns with the PR description.
  • Reason this comment was not posted:
    Confidence changes required: 0%
    The change in the code ensures that the 'ts' field is not included in the group tags for table panel types. This is correctly reflected in the test cases, where the expected queries for table panel types no longer include 'ts'.

Workflow ID: wflow_dZaaMKACIMCtafDB


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@srikanthccv
Copy link
Member

Can you help me understand what is the issue that necessitated removing ts?

@nityanandagohain
Copy link
Member Author

@srikanthccv it's because of this #5908 (comment) . We have removed ts from panelTypeTable. Because of which expressions are failing in table panel types as it's trying to select timestamp from the subqueries and ts is not present in those subqueries.

@nityanandagohain nityanandagohain enabled auto-merge (squash) November 12, 2024 07:50
@nityanandagohain nityanandagohain merged commit d5523fc into develop Nov 12, 2024
16 checks passed
@nityanandagohain nityanandagohain deleted the fix/qb-expr branch November 12, 2024 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working docs not required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants