-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: ignore ts for panel type table #6419
Conversation
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
1 similar comment
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Reviewed everything up to 2486059 in 28 seconds
More details
- Looked at
49
lines of code in2
files - Skipped
0
files when reviewing. - Skipped posting
1
drafted comments based on config settings.
1. pkg/query-service/app/queryBuilder/query_builder.go:119
- Draft comment:
The condition to exclude 'ts' from groupTags for table panel types is correct and aligns with the PR description. - Reason this comment was not posted:
Confidence changes required:0%
The change in the code ensures that the 'ts' field is not included in the group tags for table panel types. This is correctly reflected in the test cases, where the expected queries for table panel types no longer include 'ts'.
Workflow ID: wflow_dZaaMKACIMCtafDB
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
Can you help me understand what is the issue that necessitated removing ts? |
@srikanthccv it's because of this #5908 (comment) . We have removed ts from panelTypeTable. Because of which expressions are failing in table panel types as it's trying to select timestamp from the subqueries and ts is not present in those subqueries. |
Since we don't have ts in table panel, it should not be there in expressions.
Important
Excludes
ts
from group tags in queries for table panel types inquery_builder.go
, with corresponding test updates inquery_builder_test.go
.query_builder.go
,expressionToQuery()
now excludests
fromgroupTags
ifPanelType
isv3.PanelTypeTable
.query_builder_test.go
to reflect changes in expected queries for table panel types, ensuringts
is not included.This description was created by for 2486059. It will automatically update as commits are pushed.