Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix api query context #6268

Merged
merged 3 commits into from
Oct 25, 2024

Conversation

shivanshuraj1333
Copy link
Member

@shivanshuraj1333 shivanshuraj1333 commented Oct 25, 2024

Important

Update query context handling in http_handler.go and translator.go for producer-topic-throughput.

  • Behavior:
    • Change query context in getPartitionOverviewLatencyData() in http_handler.go from partition_latency to producer-topic-throughput.
  • Query Handling:
    • Remove producer-topic-throughput from conditional check in BuildClickHouseQuery() in translator.go.

This description was created by Ellipsis for 728ec96. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 728ec96 in 42 seconds

More details
  • Looked at 26 lines of code in 2 files
  • Skipped 0 files when reviewing.
  • Skipped posting 2 drafted comments based on config settings.
1. pkg/query-service/app/integrations/messagingQueues/kafka/translator.go:256
  • Draft comment:
    The 'producer-topic-throughput' context was removed from the conditional check, but it is still used in the code. Ensure that this context is handled correctly elsewhere in the codebase.
  • Reason this comment was not posted:
    Comment did not seem useful.
2. pkg/query-service/app/integrations/messagingQueues/kafka/translator.go:254
  • Draft comment:
    Do not add non-ClickHouse related functions like producer-topic-throughput to BuildClickHouseQuery. Use the DAO in the telemetry instance instead.
  • Reason this comment was not posted:
    Marked as duplicate.

Workflow ID: wflow_TM7Cc1hkFj3cJB21


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Copy link

request-info bot commented Oct 25, 2024

We would appreciate it if you could provide us with more info about this issue/pr!

@shivanshuraj1333 shivanshuraj1333 merged commit a31c4b8 into SigNoz:develop Oct 25, 2024
12 of 13 checks passed
@prashant-shahi
Copy link
Member

@shivanshuraj1333 I believe you need to move the environment to the actual command that is executed instead of the CI environment.

export KAFKA_SPAN_EVAL="true"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants