-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add process list #6125
chore: add process list #6125
Conversation
@srikanthccv this needs some resolution, overall LGTM |
Some of the abstraction can be done if you use a data model for the metrics, however, this structuring of the code might require some time. For now maybe having a common file, something like constant.go or metrics_names.go can be used to put the const metrics name. But that'd wouldn't be a blocker, if you want to merge the PR, go ahead. |
@shivanshuraj1333 Good points about the constant metric names. I will add them in follow-up PR as I will be doing similar stuff in upcoming PRs. Can you elaborate on the abstraction part? Are you referring to the part where the hosts and process list look mostly the same? If so, I agree with that but personally I let the codebase evolve over some time and then refactor with better abstractions. |
Summary
Part of #5373
The v0 planned items here https://www.notion.so/signoz/V0-infra-monitoring-items-a3e94f6e80a94b33b42874d2f414edeb
This change adds the v0.1-0.3 item mentioned in https://www.notion.so/signoz/Infra-monitoring-epic-iterations-plan-05407ddb3d6a4ea7a0f59093cda93fc8, i.e. the ability to see the list of processes with name, cpu and memory metrics.