fix: fixed threshold for columns with units #6079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
SagarRajput-7
force-pushed
the
SIG-5262
branch
from
eb67731
to
2d9718b
Compare
SagarRajput-7
force-pushed
the
SIG-5262
branch
from
088aeb4
to
18d2062
Compare
rahulkeswani101
previously approved these changes
Oct 7, 2024
ahmadshaheer
previously approved these changes
Oct 14, 2024
YounixM
reviewed
Oct 14, 2024
frontend/src/container/NewWidget/RightContainer/Threshold/Threshold.styles.scss
Outdated
Show resolved
Hide resolved
|
@SagarRajput-7 please add necessary code comments to the functions, params , returns and what is it doing as well. it's hard to follow up without that |
SagarRajput-7
dismissed stale reviews from ahmadshaheer and rahulkeswani101
via
6b768b4
@vikrantgupta25 - added please check |
SagarRajput-7
commented
Oct 18, 2024
SagarRajput-7
commented
Oct 18, 2024
frontend/src/container/NewWidget/RightContainer/dataFormatCategories.ts
Outdated
Show resolved
Hide resolved
…cross different unit types
SagarRajput-7
force-pushed
the
SIG-5262
branch
from
70db4f7
to
b92740c
Compare
vikrantgupta25
approved these changes
Oct 18, 2024
SagarRajput-7
requested review from
ahmadshaheer,
rahulkeswani101 and
YounixM
YounixM
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Additionally:
nstomsRelated Issues / PR's
#5262
Screenshots
Screen.Recording.2024-10-03.at.6.49.43.PM.mov
Affected Areas and Manually Tested Areas